Skip to content

implement clearer UX for transparent color in color picker #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

junnjiee
Copy link
Contributor

@junnjiee junnjiee commented Jul 17, 2025

Context

Fixes #4081

Implementation

image image

Instead of an X symbol, a transparent color icon is used to hint that the button removes the color.

Copy link

vercel bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 11:12am

Copy link

vercel bot commented Jul 17, 2025

@junnjiee is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (988c6fd) to head (f85e2ed).
Report is 124 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4111      +/-   ##
==========================================
- Coverage   54.52%   53.01%   -1.51%     
==========================================
  Files         274      288      +14     
  Lines        6076     6675     +599     
  Branches     1455     1632     +177     
==========================================
+ Hits         3313     3539     +226     
- Misses       2763     3136     +373     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearer UX required for transparent color in color picker
1 participant