Fix duplicated licenses #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "Warning: Each child in a list should have a unique "key" prop." and fixes displayed duplicates inside filters: - Apache License 2.0 (2) - Apache License 2.0 (23) - CC-PDDC (1) - MIT License (1) - MIT License (3)
✅ Deploy Preview for oasisprotocol-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lukaw3d
commented
Jul 28, 2025
Comment on lines
+13
to
+20
| const formatLicense = (license) => { | ||
| if (!license) return 'Unspecified'; | ||
| if (license.toLowerCase() === 'mit') return 'MIT License'; | ||
| if (license.toLowerCase() === 'apache-2.0') return 'Apache License 2.0'; | ||
| if (license.toLowerCase() === 'gpl-3.0') return 'GNU General Public License v3.0'; | ||
| if (license.toLowerCase() === 'bsd-3-clause') return 'BSD 3-Clause License'; | ||
| return license; | ||
| }; |
There was a problem hiding this comment.
Instead of these workarounds can we have good data instead?
There was a problem hiding this comment.
Data is fed directly from github.com API and SPDX license IDs are defined here https://spdx.org/licenses/ So the idea is to have the license IDs in projects.json and the UI around it then formats it accordingly. Or was there something else you had in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Warning: Each child in a list should have a unique "key" prop." and fixes displayed duplicates inside filters:
