Allow instantiation of multiple notebooks inside a single scope #40
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gordon Smith <[email protected]>
mbostock
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Makes sense; we should generalize this to be more object-oriented. I think the pattern should probably be to instantiate something, an object that owns the runtime and the main module, and then call define on the instantiated object as a method, rather than passing the main module through to define.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWIW I am creating notebooks at runtime (rather than build time) and having a single runtime/main is problematic.