Skip to content

add fees on escrow #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add fees on escrow #916

wants to merge 6 commits into from

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented May 27, 2025 •
edited
Loading

Fixes #906 and #919

Changes proposed in this PR:

  • add fees on claims (using Factory settings)
  • allow custom OPC Collector (not the one configured in Factory)
  • add list of tokens per user (easier UX)

@alexcos20 alexcos20 self-assigned this May 27, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems May 27, 2025
View reviewed changes
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented May 27, 2025 •
edited
Loading

add fees on escrow

Generated at commit: dcf38d13c6539329d1a76379c6bb5a181290b96b

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
1
0
9
40
52
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

This was linked to issues Jun 23, 2025
escrow fees #906
Open
Escrow: list of tokens for an user #919
Open
@alexcos20 alexcos20 marked this pull request as ready for review June 23, 2025 06:45
@alexcos20 alexcos20 requested a review from trentmc as a code owner June 23, 2025 06:45
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 23, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc Awaiting requested review from trentmc trentmc is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Escrow: list of tokens for an user escrow fees
1 participant
@alexcos20