Add dropdown demo #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesnw I have some style cleanup edits I thought would be easier to do locally. Could you grant me access here? |
|
@dvdherron Whoops, sorry- you should have access now! |
dvdherron
reviewed
Sep 25, 2025
|
@stacyk This is ready for style review whenever you're ready |
jamesnw
commented
Sep 26, 2025
src/dropdown/style.css
Outdated
Comment on lines
36
to
39
| ul { | ||
| position-area: span-block-end inline-end; | ||
| position-try: block-end span-inline-end; | ||
| } |
There was a problem hiding this comment.
@dvdherron Is this the clearest way of selecting 2nd level menus? I'm wondering if the selector should be .menu here as well?
There was a problem hiding this comment.
Oh, I thought I saw the .menu selector on the submenus- but I didn't. Should there be?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yup, that's great! Thanks! I think that's clearer than just basing it on semantics and hierarchy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
npx http-server .Open http://localhost:8080/src/dropdown