Freebsd: Fixed 'write' syscall to cause 'ESPIPE' on the pipe fd. #5575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use
posix.pipe()
to create a bidirectional pipe that allows you to write to one end and read from the other end, you will find that thewrite
syscall will causeespipe
error!Here is the minimal example to prove that:
Then the
error
will beespipe
!!!But if you use
posix.write
, it works expected:So, if you look into
$ODIN_ROOT/core/sys/freebsd/syscalls.odin
, you will see that thewrite
procedure actually callSYS_pwrite
syscall which is wrong!Since
pwrite
requires an offset, which in turn triggers alseek/seek
call, it will fail when the file descriptor belongs to a pipe.If you run
man 2 write
, you should see the following description about that: