Skip to content

[IMP] Lunch: Update orders #13632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

Conversation

larm-odoo
Copy link
Contributor

Updating to new standards and updating images.

Task card for this PR.

@larm-odoo larm-odoo self-assigned this Jun 9, 2025
@robodoo
Copy link
Collaborator

robodoo commented Jun 9, 2025

Pull request status dashboard

@larm-odoo larm-odoo added the 2 label Jun 9, 2025
@larm-odoo larm-odoo requested a review from slinkous June 9, 2025 20:35
@C3POdoo C3POdoo requested a review from a team June 9, 2025 20:36
@larm-odoo
Copy link
Contributor Author

Hi @slinkous - this is ready for a peer review when you have a moment!

Copy link
Contributor

@slinkous slinkous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update. There was one line (mostly from previous version) that I called out as confusing. The rest is superficial stuff.

@larm-odoo larm-odoo force-pushed the 18.0-lunch-update-orders-larm branch from e41ff2d to 4557796 Compare June 10, 2025 17:50
@larm-odoo larm-odoo requested a review from a team June 10, 2025 17:51
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - this is ready for a final review!

@larm-odoo
Copy link
Contributor Author

Hi @samueljlieber - per @Felicious , this can go directly to you for a tech review since it's just a 2 pointer. Thanks!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @larm-odoo 😊

Comment on lines -7 to +8
When the *Lunch* application is opened, the :guilabel:`Order Your Lunch` dashboard loads. This view
is also accessed by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`.
When the **Lunch** application is opened, the :guilabel:`Order Your Lunch` dashboard loads. This
view is also accessible by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s start this article by introducing what the feature does and how it helps users 😊 What you’ve written makes a great second paragraph for explaining how to open the page in Odoo!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here' a chatgpt-suggested intro. Can you check if it's accurate? And since you know this app best, if you can list an even better value proposition for the features, go for it!! 😍

The Lunch app lets employees place lunch orders, see what’s available each day, and check their account balance. It’s a simple way for teams to manage lunch orders from one place.

potential :guilabel:`Extras` field, showcasing any :ref:`extra items or options <lunch/extras>`.
Tick the checkbox next to any desired extras present in the :guilabel:`Extras` field to add them to
At the top of the pop-up window is the product image, name, and price. Beneath that, there are
potential :guilabel:`Extras` fields, showcasing any :ref:`extra items or options <lunch/extras>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give some examples so the reader can conceptualize what these are! (:

Suggested change
potential :guilabel:`Extras` fields, showcasing any :ref:`extra items or options <lunch/extras>`.
potential :guilabel:`Extras` fields, showcasing any :ref:`extra items or options <lunch/extras>`, such as pizza toppings or discounted soda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants