Skip to content

Various server CLI #14294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Various server CLI #14294

wants to merge 5 commits into from

Conversation

Julien00859
Copy link
Member

I'll backport most of them in their appropriate version, but it helps me to have them all in master first.

[FIX] developer/reference/cli: --db_replica_host

Introduced by odoo/odoo#112000 in 17.0

[FIX] developer/reference/cli: --dev=replica

Introduced by odoo/odoo#195280 in saas-18.1

[FIX] developer/reference/cli: --dev=pdb was removed

Does nothing since odoo/odoo#78857 and was removed in odoo/odoo#115076
both in 16.0.

[FIX] developer/reference/cli: --dev=all is a lie

--dev=all actually means --dev=xml,qweb,reload

[IMP] developer/reference/cli: --dev=access

@robodoo
Copy link
Collaborator

robodoo commented Aug 13, 2025

Pull request status dashboard

@Julien00859 Julien00859 force-pushed the master-core-dev-mode-access branch from 988a686 to 5ee04f6 Compare August 13, 2025 15:06
@C3POdoo C3POdoo requested a review from a team August 13, 2025 15:09
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

Runbot is red 👀

Also, you should avoid referencing PRs in your commit messages. Those PRs will quickly be spammed by "someone pushed a commit that references this" notifications that are logged each time you or robodoo ( 👋 forward-ports) push/force-push your commits.


.. option:: --db_replica_port <port>

port the replica database listens on, defaults to :option:`--db_port`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
port the replica database listens on, defaults to :option:`--db_port`
the port the replica database listens on, defaults to :option:`--db_port`

Comment on lines +436 to +438
* ``replica``: simulate :option:`db_replica_host` but connect to the same datbase server as
:option:`db_host`, this makes it possible to test read-only features without the need to setup
a replicated database.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* ``replica``: simulate :option:`db_replica_host` but connect to the same datbase server as
:option:`db_host`, this makes it possible to test read-only features without the need to setup
a replicated database.
* ``replica``: simulate :option:`db_replica_host` but connect to the same database server as
:option:`db_host`, this makes it possible to test read-only features without the need to set up
a replicated database.

Comment on lines +440 to +441
* ``access``: log the traceback next to the AccessError when it results as a 403 - Forbidden
HTTP response.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* ``access``: log the traceback next to the AccessError when it results as a 403 - Forbidden
HTTP response.
* ``access``: log the traceback next to the AccessError when it results in a 403 - Forbidden
HTTP response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants