Skip to content

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Aug 6, 2025

OFFSET is part of the formulas which depednencies need to be dynamically added during its evaluation by interpreting their arguments. Unfortunately, the implementation was wrongly mistakenly assigning the dependency to the sheet of the currently evaluated cell instead of the the sheetId of the actual cell reference.

Task: 5001405

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

OFFSET is part of the formulas which depednencies need to be dynamically
added during its evaluation by interpreting their arguments.
Unfortunately, the implementation was wrongly mistakenly assigning the
dependency to the sheet of the currently evaluated cell instead of the
the sheetId of the actual cell reference.

Task: 5001405
@robodoo
Copy link
Collaborator

robodoo commented Aug 6, 2025

Pull request status dashboard

Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants