[FIX] composer: set cursor on prettified formula #7166
Conversation
|
|
LucasLefevre
force-pushed
the
19.0-prettified-cursor-lul
branch
from
05565e2 to
0658513
Compare
| const content = text || this.getComposerContent(this.getters.getActivePosition()); | ||
| const validSelection = this.isSelectionValid(content.length, selection.start, selection.end); | ||
| if (!validSelection) { | ||
| return; |
There was a problem hiding this comment.
This code looks like a safeguard against a programming error somewhere else, calling this with wrong values.
Keeping this check would mean making it more complex for ... not a lot...
There was a problem hiding this comment.
not the mostly pretty fix I've written...
| if (char !== "\n" && char !== "\t") { | ||
| originalIndex++; | ||
| } |
There was a problem hiding this comment.
I didn't check the prettifier feature too closely, but are we sure that there are no tabs/newlines in the formula before the prettification ? Otherwise your fix wo'nt work
There was a problem hiding this comment.
are we sure that there are no tabs/newlines in the formula before the prettification
yes, because we explicitly display it in a single line
There was a problem hiding this comment.
But it's quite fragile and confusing to understand, I admit. because the cursor is linked to the one-liner that is displayed in the composer, but the content comes from somewhere else (the cell)
src/components/composer/standalone_composer/standalone_composer_store.ts
Outdated
Show resolved
Hide resolved
LucasLefevre
force-pushed
the
19.0-prettified-cursor-lul
branch
from
0658513 to
0cf12d7
Compare
Steps to reproduce: - type a long formula, e.g. =SUM(11111111, 22222222, 33333333, 44444444, 55555555, 66666666, 77777777, 88888888) - in the top bar composer, click somewhere that won't be on the first line when prettified (in the fours) => the cursor is badly positioned on the prettified formula Task: 5095470
LucasLefevre
force-pushed
the
19.0-prettified-cursor-lul
branch
from
0cf12d7 to
d534336
Compare
|
@rrahir fixed :) |
|
thanks :) robodoo r+ |
4 participants
Steps to reproduce:
=> the cursor is badly positioned on the prettified formula
Task: 5095470
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist