Skip to content

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Sep 22, 2025

When adding the dependencies of the computed measures, we would not filter out references to inexistant sheets. This added wrong dependencies to the graph and would trigger false positives for the invalidation of the concerned pivot.

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

When adding the dependencies of the computed measures, we would not
filter out references to inexistant sheets. This added wrong
dependencies to the graph and would trigger false positives for the
invalidation of the concerned pivot.

Task: 0
@robodoo
Copy link
Collaborator

robodoo commented Sep 22, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants