[PERF] evaluation: zonify dependencies #7193
Closed
+911
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasLefevre
force-pushed
the
master-compact-zone-rtree-lul
branch
3 times, most recently
from
5e04745 to
2f1fcaf
Compare
LucasLefevre
force-pushed
the
master-compact-zone-rtree-lul
branch
4 times, most recently
from
7f3c8c5 to
33e3fdc
Compare
LucasLefevre
commented
Oct 3, 2025
Comment on lines
+187
to
+201
| const rTreeItems: RTreeItem<BoundedRange>[] = []; | ||
| for (const sheetId of this.getters.getSheetIds()) { | ||
| const cells = this.getters.getCells(sheetId); | ||
| for (const cellId in cells) { | ||
| const cell = cells[cellId]; | ||
| if (cell.isFormula) { | ||
| const directDependencies = cell.compiledFormula.dependencies; | ||
| for (const range of directDependencies) { | ||
| if (range.invalidSheetName || range.invalidXc) { | ||
| continue; |
There was a problem hiding this comment.
A lot more dégueulasse, but with way less array allocations
LucasLefevre
force-pushed
the
master-compact-zone-rtree-lul
branch
2 times, most recently
from
aac79fd to
deb728a
Compare
LucasLefevre
changed the title
LucasLefevre
force-pushed
the
master-compact-zone-rtree-lul
branch
3 times, most recently
from
a559079 to
7b26fbd
Compare
rrahir
reviewed
Oct 21, 2025
|
|
||
| insert(item: RTreeRangeItem) { | ||
| const data = this.rTree.search(item.boundingBox); | ||
| const exactBoundingBox = data.find((d) => deepEquals(d.boundingBox, item.boundingBox)); |
There was a problem hiding this comment.
maybe replace all deepEquals with a straight comparison since we know the structure of a boundingbox ?
There was a problem hiding this comment.
Seems worth it
https://jsperf.app/pifawe
LucasLefevre
force-pushed
the
master-compact-zone-rtree-lul
branch
2 times, most recently
from
6421c4d to
ebe5285
Compare
This commit improves evaluation time from 5% to 20% on regular spreadsheet, depending on the spreadsheet. And even from 99% on some pathological cases Benchmark: https://www.odoo.com/odoo/documents/d9dGIrjZRTSa9nf153wEIwo9e4c5 Let’s say you have two formulas that depend on the same reference: A1: =C1 A2: =C1 In the FormulaDependencyGraph, both dependencies are added independently. Specifically, the R-tree data structure ends up with two separate entries: C1 -> A1 and C1 -> A2. Ideally, the internal R-tree structure should group these dependencies into a single node in the tree: C1 -> [A1, A2] or even C1 -> [A1:A2] because they can be grouped into a single zone. When this pattern occurs frequently, the R-tree becomes huged (and unbalanced) therefore sub-optimal. - Huge: lots and lots of individual positions - Unbalanced: this is common when using individual pivot formulas (e.g., for spreadsheet pivots), where each PIVOT.VALUE formula depends on the same range—the pivot dataset. With this commit, the dependencies R-Tree maps bounding boxes to zones, instead of bounding boxes to positions. To take advantage of this grouping, the entire evaluation process now uses zones as much as possible. Task: 4936229
rrahir
force-pushed
the
master-compact-zone-rtree-lul
branch
from
ebe5285 to
c1b1527
Compare
|
backported in 19.0 #7358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
performance measures: https://www.odoo.com/odoo/documents/d9dGIrjZRTSa9nf153wEIwo9e4c5
Task: 4936229
review checklist