[FIX] RibbonMenu: reset scroll value on menu exploration #7194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
How to reproduce: - Open the ribbon menu - select "insert" - scroll the menu completely - select "Functions" The scroll is persistent from the previous menu and we arrive in the `Functions` menu already scrolled, issue that is highlighted by the fact that scrollbars are hidden by defaut on mobile browsers. This revision resets the scroll when ;oving from one menu section to the other. Task: 5106796
rrahir
force-pushed
the
saas-18.4-fix-ribbon-menu-scroll-rar
branch
from
8548645 to
468e539
Compare
hokolomopo
reviewed
Sep 26, 2025
| test("Spam click on the arrow button scrolls a lot", async () => { | ||
| let scrollTo = 0; | ||
| //@ts-ignore - scrollTo is not defined in JSDOM | ||
| sheetListEl.scrollTo = (arg: ScrollToOptions) => { |
There was a problem hiding this comment.
Is scrollTo in JSDOM now ? 😮
Edit: NEVERMIND you added it in the jest.setup. For a second, I was hoping JSDOM was getting good 😢
| .o-ribbon-menu-wrapper { | ||
| max-height: 100%; | ||
|
|
||
| &.scroll-top::before { |
There was a problem hiding this comment.
css seems a bit broken, the left/right side of the menu also have a shadow for me ...
There was a problem hiding this comment.
apparently this behaves dfferently on miobile devices (perharps per browser/os ) i will change the strategy
Currently, it is not quite clear that the ribbon menu can be scrolled as the scrollbars are not displayed by default on a mobile browser (or on some desktop browsers like firefox). This revision adds some style that will hint the possibility to scroll either to the bottom or top of the menu depending on the current scrolling value. Task: 5106796
rrahir
force-pushed
the
saas-18.4-fix-ribbon-menu-scroll-rar
branch
from
468e539 to
9165a5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
The scroll is persistent from the previous menu and we arrive in the
Functionsmenu already scrolled, issue that is highlighted by the fact that scrollbars are hidden by defaut on mobile browsers.This revision resets the scroll when ;oving from one menu section to the other.
[FIX] RibbonMenu: hint the scrollable menu
Currently, it is not quite clear that the ribbon menu can be scrolled as
the scrollbars are not displayed by default on a mobile browser (or on
some desktop browsers like firefox).
This revision adds some style that will hint the possibility to scroll
either to the bottom or top of the menu depending on the current
scrolling value.
Task: 5106796
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5106796
review checklist