[FIX] chart: wrong label format for date chart #7227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date charts would always have a datetime format for the labels, no matter the format of the data. They would also be truncated, which we probably don't want for dates. The issue is that the date charts had a callback for the ticks using `truncateLabel`, and `getLabelForValue` which seems bugged in date charts[1]. This commit removes the tick callback for date charts, letting the luxon time adapter format the dates. [1] chartjs/Chart.js#12128 Task: 4908471
|
|
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 8, 2025
Date charts would always have a datetime format for the labels, no matter the format of the data. They would also be truncated, which we probably don't want for dates. The issue is that the date charts had a callback for the ticks using `truncateLabel`, and `getLabelForValue` which seems bugged in date charts[1]. This commit removes the tick callback for date charts, letting the luxon time adapter format the dates. [1] chartjs/Chart.js#12128 closes #7227 Task: 4908471 Signed-off-by: Rémi Rahir (rar) <[email protected]>
This was referenced Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Date charts would always have a datetime format for the labels, no matter the format of the data. They would also be truncated, which we probably don't want for dates.
The issue is that the date charts had a callback for the ticks using
truncateLabel, andgetLabelForValuewhich seems bugged in date charts[1].This commit removes the tick callback for date charts, letting the luxon time adapter format the dates.
[1] chartjs/Chart.js#12128
Task: 4908471
review checklist