Skip to content

[IMP] headers: add icons to header group context menu #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[IMP] headers: add icons to header group context menu #7240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/components/icons/icons.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,4 +1032,20 @@
/>
</svg>
</t>
<t t-name="o-spreadsheet-Icon.COLLAPSE">
<svg class="o-icon" viewBox="0 0 18 18">
<path
d="M12.124 2.576a.6.6 0 0 1 0 .848l-2.7 2.7a.6.6 0 0 1-.848 0l-2.7-2.7a.6.6 0 0 1 .848-.848L8.4 4.2V.9a.6.6 0 0 1 1.2 0v3.3l1.676-1.624a.6.6 0 0 1 .848 0M5.876 15.424a.6.6 0 0 1 0-.848l2.7-2.7a.6.6 0 0 1 .848 0l2.7 2.7a.6.6 0 0 1-.848.848L9.6 13.8v3.3a.6.6 0 0 1-1.2 0v-3.3l-1.676 1.624a.6.6 0 0 1-.848 0M2 7a.5.5 0 0 0 0 1h14a.5.5 0 0 0 0-1M2 10a.5.5 0 0 0 0 1h14a.5.5 0 0 0 0-1"
fill="currentColor"
/>
</svg>
</t>
<t t-name="o-spreadsheet-Icon.EXPAND">
<svg class="o-icon" viewBox="0 0 18 18">
<path
d="M5.876 14.076a.6.6 0 0 0 0 .848l2.7 2.7a.6.6 0 0 0 .848 0l2.7-2.7a.6.6 0 0 0-.848-.848L9.6 15.7v-3.3a.6.6 0 0 0-1.2 0v3.3l-1.676-1.624a.6.6 0 0 0-.848 0m6.248-10.152a.6.6 0 0 0 0-.848l-2.7-2.7a.6.6 0 0 0-.848 0l-2.7 2.7a.6.6 0 0 0 .848.848L8.4 2.3v3.3a.6.6 0 0 0 1.2 0V2.3l1.676 1.624a.6.6 0 0 0 .848 0M2 10a.5.5 0 0 0 0 1h14a.5.5 0 0 0 0-1M2 7a.5.5 0 0 0 0 1h14a.5.5 0 0 0 0-1"
fill="currentColor"
/>
</svg>
</t>
</templates>
8 changes: 8 additions & 0 deletions src/registries/menus/header_group_registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@ export function createHeaderGroupContainerContextMenu(
execute: (env) => {
env.model.dispatch("UNFOLD_ALL_HEADER_GROUPS", { sheetId, dimension });
},
icon: "o-spreadsheet-Icon.EXPAND",
},
{
id: "fold_all",
name: dimension === "ROW" ? _t("Collapse all row groups") : _t("Collapse all column groups"),
execute: (env) => {
env.model.dispatch("FOLD_ALL_HEADER_GROUPS", { sheetId, dimension });
},
icon: "o-spreadsheet-Icon.COLLAPSE",
},
]);
}
Expand All @@ -49,6 +51,11 @@ export function getHeaderGroupContextMenu(
const sheetId = env.model.getters.getActiveSheetId();
interactiveToggleGroup(env, sheetId, dimension, start, end);
},
icon: (env) => {
const sheetId = env.model.getters.getActiveSheetId();
const groupIsFolded = env.model.getters.isGroupFolded(sheetId, dimension, start, end);
return groupIsFolded ? "o-spreadsheet-Icon.EXPAND" : "o-spreadsheet-Icon.COLLAPSE";
},
},
{
id: "remove_group",
Expand All @@ -57,6 +64,7 @@ export function getHeaderGroupContextMenu(
const sheetId = env.model.getters.getActiveSheetId();
env.model.dispatch("UNGROUP_HEADERS", { sheetId, dimension, start, end });
},
icon: "o-spreadsheet-Icon.TRASH",
separator: true,
},
]);
Expand Down