Skip to content

Conversation

LucasLefevre
Copy link
Collaborator

Description:

Commit d8db270 mistakenly remove the css for the composer placeholder. Standalone composer were all missing their placeholder

Task: 5139499

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Commit d8db270 mistakenly remove the css for the composer placeholder.
Standalone composer were all missing their placeholder

Task: 5139499
@robodoo
Copy link
Collaborator

robodoo commented Oct 3, 2025

Pull request status dashboard


.o-composer[placeholder]:empty:not(:focus):not(.active)::before {
content: attr(placeholder);
color: #bdbdbd;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the existing --os-gray-xxx seem to be a good fit for this. I'm just keeping the value as it was before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants