Skip to content

[IMP] util/records: skip replace if all ids are the same #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] util/records: skip replace if all ids are the same #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/base/tests/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,6 +1449,11 @@ def test_replace_record_references_batch__uniqueness(self):
[count] = self.env.cr.fetchone()
self.assertEqual(count, 1)

@mute_logger("odoo.upgrade.util.records")
def test_replace_record_references_batch__idem_mapping(self):
# This logs a warning but shouldn't fail
util.replace_record_references_batch(self.env.cr, {1: 1, 2: 2}, "res.country")

def _prepare_test_delete_unused(self):
def create_cat():
name = f"test_{uuid.uuid4().hex}"
Expand Down
3 changes: 3 additions & 0 deletions src/util/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,6 +1469,9 @@ def replace_record_references_batch(cr, id_mapping, model_src, model_dst=None, r
if same_ids:
_logger.warning("Replace references in model `%s`, ignoring same-id mapping `%s`", model_src, same_ids)
id_mapping = {k: v for k, v in id_mapping.items() if k != v}
if not id_mapping:
_logger.warning("Nothing to replace in model `%s`, ignoring empty mapping", model_src)
return

assert id_mapping
assert all(isinstance(v, int) and isinstance(k, int) for k, v in id_mapping.items())
Expand Down