Skip to content

Prefer BigDecimal over Float #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prefer BigDecimal over Float #372

wants to merge 1 commit into from

Conversation

jgaskins
Copy link

@jgaskins jgaskins commented Aug 1, 2025

IEEE754 floats often have rounding errors when doing math with them. Using BigDecimal avoids these rounding errors.

To reproduce:

[1] pry(main)> Unit.new("3.5g").convert_to("mg").scalar
=> 3500.0000000000005

With this PR, we get precisely 3500:

[1] pry(main)> Unit.new("3.5g").convert_to("mg").scalar
=> 0.35e4

@jgaskins
Prefer BigDecimal over Float
eeeca2b 
IEEE754 floats often have rounding errors when doing math with them. We
want to use BigDecimal as a way to correct this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jgaskins