Skip to content

Graceful exit on smf context init failure #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 1, 2025
+6 −1
Merged

Graceful exit on smf context init failure #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1eb2785
chore(deps): bump github.com/docker/docker (#424)
dependabot[bot] Jun 10, 2025
e222935
Give up if name resolution fails
protohuf Jun 16, 2025
d17fa0e
Fail gracefully on smf context init failure
protohuf Jun 16, 2025
091bdcd
Merge branch 'main' into graceful_exit_on_smf_context_init_failure
gab-arrobo Jun 19, 2025
7b21e55
Merge branch 'main' into graceful_exit_on_smf_context_init_failure
gab-arrobo Jun 19, 2025
620e535
Merge branch 'main' into graceful_exit_on_smf_context_init_failure
gab-arrobo Jun 25, 2025
d82ff52
Modify log level to give clear details for the reason of process term…
gab-arrobo Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion context/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ func InitSmfContext(config *factory.Config) *SMFContext {
}
addr, err := net.ResolveUDPAddr("udp", fmt.Sprintf("%s:%d", pfcp.Addr, pfcp.Port))
if err != nil {
logger.CtxLog.Warnf("PFCP Parse Addr Fail: %v", err)
logger.CtxLog.Errorf("PFCP Parse Addr Fail: %v", err)
return nil
}

smfContext.PFCPPort = int(pfcp.Port)
Expand Down
4 changes: 4 additions & 0 deletions service/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,10 @@ func (smf *SMF) Start() {
// Init SMF Service
smfCtxt := context.InitSmfContext(&factory.SmfConfig)

if smfCtxt == nil {
logger.InitLog.Fatalln("Failed to init smf context")
}

// allocate id for each upf
context.AllocateUPFID()

Expand Down