add post-initialize function to pools and providers #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
requested changes
Aug 19, 2025
bratpiorka
approved these changes
Aug 19, 2025
Split between initialize and post-initialize function is necessary for properly handling CTL defaults.
lukaszstolarczuk
approved these changes
Aug 25, 2025
vinser52
reviewed
Aug 25, 2025
Comment on lines
+199
to
+201
| /// * Called by UMF **after** @ref initialize during umfPoolCreate(). | ||
| /// * Between @ref initialize and @ref ext_post_initialize there **may** be | ||
| /// multiple calls to @ref ext_ctl for early configuration. |
There was a problem hiding this comment.
It is unclear how pool/provider developer should decide how initialization steps should be split between initialize and ext_post_initialize
There was a problem hiding this comment.
Honestly, I think it is an error-prone approach
KFilipek
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cont: #1467
Description
Checklist