Skip to content

Evaluate Ktorfit (WIP) #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Evaluate Ktorfit (WIP) #124

wants to merge 1 commit into from

Conversation

opatry
Copy link
Owner

@opatry opatry commented May 9, 2025 •
edited
Loading

Description

  • Need to double check Gzip compression (why was only made in insert initially? Might worth investigating input payload and responses compression in all relevant APIs)

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@opatry opatry marked this pull request as draft May 9, 2025 17:12
opatry
opatry commented May 9, 2025
View reviewed changes
google/tasks/src/commonMain/kotlin/net/opatry/google/tasks/TaskListsApi.kt
suspend fun insert(taskList: TaskList): TaskList
@Headers(
"Content-Type: application/json",
"Content-Encoding: gzip",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really the way to go?
Need confirmation.

opatry
opatry commented May 9, 2025
View reviewed changes
google/tasks/src/commonMain/kotlin/net/opatry/google/tasks/TasksApi.kt
suspend fun insert(taskListId: String, task: Task, parentTaskId: String? = null, previousTaskId: String? = null): Task
@Headers(
"Content-Type: application/json",
"Content-Encoding: gzip",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really the way to go?
Need confirmation.

opatry
opatry commented May 9, 2025
View reviewed changes
tasks-app-shared/src/commonMain/kotlin/net/opatry/tasks/app/di/networkModule.kt
}

single {
// FIXME why ktorfit.createTaskListsApi() isn't generated?
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need investigation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025

©️ Stale credits for :tasks-app-desktop

diff --git a/tasks-app-desktop/src/main/resources/licenses_desktop.json b/tasks-app-desktop/src/main/resources/licenses_desktop.json
index ec37965..bbe4f85 100644
--- a/tasks-app-desktop/src/main/resources/licenses_desktop.json
+++ b/tasks-app-desktop/src/main/resources/licenses_desktop.json
@@ -260,6 +260,20 @@
"name": "com.typesafe"
}
},
+ {
+ "uniqueId": "de.jensklingenberg.ktorfit:ktorfit-lib",
+ "developers": [
+ {
+ "name": "Jens Klingenberg"
+ }
+ ],
+ "artifactVersion": "2.5.1",
+ "description": "Ktorfit",
+ "name": "Ktorfit",
+ "licenses": [
+ "Apache-2.0"
+ ]
+ },
{
"uniqueId": "io.coil-kt.coil3:coil",
"developers": [

Run ./gradlew :tasks-app-desktop:exportLibraryDefinitions and commit resulting diff to fix the issue.

@opatry opatry added help wanted 🛟 Extra attention is needed question 🙋 Further information is requested labels May 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025

Job Summary for Gradle

Build & Test :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
Taskfolio :tasks-app-desktop:assemble 8.12.1 ❌ Build Scan not published
Taskfolio :tasks-app-desktop:exportLibraryDefinitions 8.12.1 ✅ Build Scan not published

@github-actions GitHub Actions
Copy link
Contributor

©️ Stale credits for :tasks-app-desktop

diff --git a/tasks-app-desktop/src/main/resources/licenses_desktop.json b/tasks-app-desktop/src/main/resources/licenses_desktop.json
index 435f527..f681c1e 100644
--- a/tasks-app-desktop/src/main/resources/licenses_desktop.json
+++ b/tasks-app-desktop/src/main/resources/licenses_desktop.json
@@ -260,6 +260,20 @@
"name": "com.typesafe"
}
},
+ {
+ "uniqueId": "de.jensklingenberg.ktorfit:ktorfit-lib",
+ "developers": [
+ {
+ "name": "Jens Klingenberg"
+ }
+ ],
+ "artifactVersion": "2.5.1",
+ "description": "Ktorfit",
+ "name": "Ktorfit",
+ "licenses": [
+ "Apache-2.0"
+ ]
+ },
{
"uniqueId": "io.coil-kt.coil3:coil",
"developers": [

Run ./gradlew :tasks-app-desktop:exportLibraryDefinitions -Pci=true and commit resulting diff to fix the issue.

@github-actions GitHub Actions
Copy link
Contributor

Job Summary for Gradle

Build & Test :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
Taskfolio :tasks-app-desktop:assemble 8.12.1 ❌ Build Scan not published
Taskfolio :tasks-app-desktop:exportLibraryDefinitions 8.12.1 ✅ Build Scan not published

@github-actions GitHub Actions
Copy link
Contributor

Job Summary for Gradle

Build & Test :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
Taskfolio :tasks-app-desktop:assemble 8.12.1 ❌ Build Scan not published
Taskfolio :tasks-app-desktop:exportLibraryDefinitions 8.12.1 ✅ Build Scan not published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted 🛟 Extra attention is needed question 🙋 Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@opatry