-
Notifications
You must be signed in to change notification settings - Fork 5
Add operator to spatial transform ts4231 data #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e1ea84e
e43429f
74c21b0
c3e951d
7944b29
25d23f8
1a1c61e
ff20c8b
41c170a
a9136bc
f39e988
0dd7784
946e203
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,243 @@ | ||
using System; | ||
using System.Linq; | ||
using System.Numerics; | ||
using System.Windows.Forms; | ||
using System.Reactive.Linq; | ||
using Bonsai.Design; | ||
using System.Collections.Generic; | ||
using System.Drawing; | ||
|
||
namespace OpenEphys.Onix1.Design | ||
{ | ||
/// <summary> | ||
/// Partial class to create a spatial-calibration GUI for <see cref="TS4231V1SpatialTransform.SpatialTransform"/>. | ||
/// </summary> | ||
public partial class SpatialTransformMatrixDialog : Form | ||
{ | ||
internal SpatialTransformProperties SpatialTransform; | ||
const byte NumMeasurements = 100; | ||
readonly IObservable<TS4231V1PositionDataFrame> PositionDataSource; | ||
IDisposable richTextBoxStatusUpdateSubscription; | ||
IDisposable MeasurementCalculationSubscription; | ||
|
||
internal SpatialTransformMatrixDialog(IObservable<TS4231V1PositionDataFrame> dataSource, SpatialTransformProperties transformProperties) | ||
{ | ||
InitializeComponent(); | ||
SpatialTransform = transformProperties; | ||
PositionDataSource = dataSource; | ||
|
||
var ts4231TextBoxes = new TextBox[] { | ||
textBoxTS4231Coordinate0, textBoxTS4231Coordinate1, | ||
textBoxTS4231Coordinate2, textBoxTS4231Coordinate3}; | ||
foreach (var (textBox, v) in Enumerable.Zip(ts4231TextBoxes, SpatialTransform.Pre, (tb, v) => (tb, v))) | ||
textBox.Text = checkVector3ForNaN(v) ? "" : $"{v.X}, {v.Y}, {v.Z}"; | ||
|
||
var userTextBoxes = new TextBox[] { | ||
textBoxUserCoordinate0X, textBoxUserCoordinate0Y, textBoxUserCoordinate0Z, | ||
textBoxUserCoordinate1X, textBoxUserCoordinate1Y, textBoxUserCoordinate1Z, | ||
textBoxUserCoordinate2X, textBoxUserCoordinate2Y, textBoxUserCoordinate2Z, | ||
textBoxUserCoordinate3X, textBoxUserCoordinate3Y, textBoxUserCoordinate3Z}; | ||
for (byte i = 0; i < 12; i++) | ||
{ | ||
ref var component = ref GetComponent(ref SpatialTransform.Post[i / 3], i % 3); | ||
userTextBoxes[i].Text = float.IsNaN(component) ? "" : component.ToString(); | ||
} | ||
|
||
CalculatePrintMatrix(); | ||
} | ||
|
||
private void TextBoxUserCoordinate_TextChanged(object sender, EventArgs e) | ||
{ | ||
var tag = Convert.ToByte(((TextBox)sender).Tag); | ||
ref var coordinateComponent = ref GetComponent(ref SpatialTransform.Post[tag / 3], tag % 3); | ||
try { coordinateComponent = float.Parse(((TextBox)sender).Text); } | ||
catch { coordinateComponent = float.NaN; } | ||
CalculatePrintMatrix(); | ||
} | ||
|
||
private void ButtonMeasure_Click(object sender, EventArgs e) | ||
{ | ||
TextBox[] ts4231TextBoxes = { textBoxTS4231Coordinate0, textBoxTS4231Coordinate1, textBoxTS4231Coordinate2, textBoxTS4231Coordinate3 }; | ||
var index = Convert.ToByte(((Button)sender).Tag); | ||
ts4231TextBoxes[index].Text = ""; | ||
SpatialTransform.Pre[index] = new(float.NaN); | ||
if (((Button)sender).Text == "Measure") | ||
{ | ||
richTextBoxStatus.SelectionColor = Color.Blue; | ||
richTextBoxStatus.AppendText($"Measurement at coordinate {index} initiated.\n"); | ||
SpatialTransform.M = null; | ||
textBoxSpatialTransformMatrix.Text = ""; | ||
((Button)sender).Text = "Cancel"; | ||
EnableButtons(false, index); | ||
|
||
var sharedPositionDataGroups = PositionDataSource | ||
.Take(NumMeasurements) | ||
.Timeout(new TimeSpan(0, 0, 5), Observable.Empty<TS4231V1PositionDataFrame>()) | ||
.Publish(); | ||
|
||
richTextBoxStatusUpdateSubscription = sharedPositionDataGroups | ||
.GroupBy(dataFrame => dataFrame.SensorIndex, dataFrame => dataFrame.Position) | ||
.SelectMany(group => group.Count().Select(count => new { Index = group.Key, MeasurementCount = count })) | ||
.Aggregate( | ||
(richTextBoxStatusUpdate: "", Count: 0), | ||
(acc, sensor) => | ||
{ | ||
var richTextBoxStatusUpdateString = $"{acc.richTextBoxStatusUpdate}{sensor.MeasurementCount} samples from sensor {sensor.Index}.\n"; | ||
return (richTextBoxStatusUpdateString, acc.Count + sensor.MeasurementCount); | ||
}, | ||
acc => (acc.richTextBoxStatusUpdate, Valid: acc.Count == NumMeasurements)) | ||
.ObserveOn(new ControlScheduler(this)) | ||
.Subscribe(finalResult => | ||
{ | ||
if (finalResult.Valid) | ||
{ | ||
richTextBoxStatus.SelectionColor = Color.Black; | ||
richTextBoxStatus.AppendText($"{finalResult.richTextBoxStatusUpdate}Measurement at coordinate {index} complete.\n\n"); | ||
} | ||
else | ||
{ | ||
richTextBoxStatus.SelectionColor = Color.Red; | ||
richTextBoxStatus.AppendText($"Measurement at coordinate {index} timed out.\n" + | ||
"Confirm the Lighthouse receivers are within range of and unobstructed from Lighthouse transmitters.\n\n"); | ||
} | ||
EnableButtons(true, index); | ||
}); | ||
|
||
MeasurementCalculationSubscription = sharedPositionDataGroups | ||
.Aggregate( | ||
(Sum: Vector3.Zero, Count: 0), | ||
(acc, current) => (acc.Sum + current.Position, acc.Count + 1), | ||
acc => | ||
{ | ||
SpatialTransform.Pre[index] = acc.Sum / NumMeasurements; | ||
return (Position: SpatialTransform.Pre[index], Valid: acc.Count == NumMeasurements); | ||
}) | ||
.ObserveOn(new ControlScheduler(this)) | ||
.Subscribe(measurement => | ||
{ | ||
((Button)sender).Text = "Measure"; | ||
if (measurement.Valid) | ||
{ | ||
ts4231TextBoxes[index].Text = $"{measurement.Position.X}, {measurement.Position.Y}, {measurement.Position.Z}"; | ||
CalculatePrintMatrix(); | ||
} | ||
}); | ||
|
||
sharedPositionDataGroups.Connect(); | ||
} | ||
else | ||
{ | ||
richTextBoxStatusUpdateSubscription.Dispose(); | ||
MeasurementCalculationSubscription.Dispose(); | ||
richTextBoxStatus.SelectionColor = Color.Red; | ||
richTextBoxStatus.AppendText($"Measurement at coordinate {index} cancelled by user.\n\n"); | ||
((Button)sender).Text = "Measure"; | ||
EnableButtons(true, index); | ||
} | ||
} | ||
|
||
private void ButtonOK_Click(object sender, EventArgs e) | ||
{ | ||
if (SpatialTransform.M.HasValue) | ||
DialogResult = DialogResult.OK; | ||
else | ||
{ | ||
var confirmationMessage = ""; | ||
var incompleteInput = false; | ||
if (SpatialTransform.Post.Any(userCoordinate => checkVector3ForNaN(userCoordinate))) | ||
{ | ||
incompleteInput = true; | ||
var axes = new char[] { 'X', 'Y', 'Z' }; | ||
var coordinates = new byte[] { 0, 1, 2, 3 }; | ||
confirmationMessage += "At least one coordinate component is empty or invalid:\n"; | ||
for (byte i = 0; i < 12; i++) | ||
{ | ||
ref var component = ref GetComponent(ref SpatialTransform.Post[i / 3], i % 3); | ||
if (float.IsNaN(component)) | ||
confirmationMessage += $" • Coordinate {coordinates[i / 3]} {axes[i % 3]} component\n"; | ||
} | ||
confirmationMessage += "\n"; | ||
} | ||
if (SpatialTransform.Pre.Any(TS4231Coordinate => checkVector3ForNaN(TS4231Coordinate))) | ||
{ | ||
incompleteInput = true; | ||
confirmationMessage += "At least one coordinate measurement is empty:\n"; | ||
foreach (var (i, v) in SpatialTransform.Pre.Select((i, v) => (v, i))) | ||
if (checkVector3ForNaN(v)) | ||
confirmationMessage += $" • Coordinate {i}\n"; | ||
confirmationMessage += "\n"; | ||
} | ||
|
||
if (incompleteInput) | ||
confirmationMessage += "They will not be saved and transformed position data won't be properly output.\n\n"; | ||
else if (!Matrix4x4.Invert(Vector3sToMatrix4x4(SpatialTransform.Post), out _)) | ||
confirmationMessage = "The spatial transform matrix is non-invertible. The transformed position data won't be properly output.\n\n"; | ||
|
||
confirmationMessage += "Would you like to continue?"; | ||
|
||
if (MessageBox.Show(confirmationMessage, "Confirmation", MessageBoxButtons.YesNo) == DialogResult.Yes) | ||
DialogResult = DialogResult.OK; | ||
} | ||
} | ||
|
||
private readonly Func<Vector3, bool> checkVector3ForNaN = v => new[] { v.X, v.Y, v.Z }.Any(float.IsNaN); | ||
|
||
private void EnableButtons(bool enable, byte index) | ||
{ | ||
var buttons = new Button[] { buttonMeasure0, buttonMeasure1, buttonMeasure2, buttonMeasure3, buttonOK, buttonCancel }; | ||
Array.ForEach(buttons, button => button.Enabled = enable || (Convert.ToByte(button.Tag) == index)); | ||
} | ||
|
||
private void CalculatePrintMatrix() | ||
{ | ||
SpatialTransform.M = null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move all of this logic the the Further, never put logic like this in a GUI. The GUI's logic should pertain to handling of GUI elements and perhaps setting the state of the object(s) the GUI represents via getters and setters. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. True. I think I achieved this now. In particular, this GUI is meant to provide the user a way of setting or viewing data in the |
||
if (!SpatialTransform.Post.Any(userCoordinate => checkVector3ForNaN(userCoordinate)) && | ||
!SpatialTransform.Pre.Any(TS4231Coordinate => checkVector3ForNaN(TS4231Coordinate))) | ||
{ | ||
if (Matrix4x4.Invert(Vector3sToMatrix4x4(SpatialTransform.Post), out _)) | ||
{ | ||
var ts4231V1CoordinatesMatrix = Vector3sToMatrix4x4(SpatialTransform.Pre); | ||
var userCoordinatesMatrix = Vector3sToMatrix4x4(SpatialTransform.Post); | ||
Matrix4x4.Invert(ts4231V1CoordinatesMatrix, out var ts4231V1CoordinatesMatrixInverted); | ||
SpatialTransform.M = Matrix4x4.Multiply(ts4231V1CoordinatesMatrixInverted, userCoordinatesMatrix); | ||
toolStripStatusLabel.Image = Properties.Resources.StatusReadyImage; | ||
toolStripStatusLabel.Text = "Spatial transform matrix is calculated."; | ||
} | ||
else | ||
{ | ||
toolStripStatusLabel.Image = Properties.Resources.StatusWarningImage; | ||
toolStripStatusLabel.Text = "The resulting spatial transform matrix must be non-invertible."; | ||
} | ||
} | ||
else | ||
{ | ||
toolStripStatusLabel.Image = Properties.Resources.StatusWarningImage; | ||
toolStripStatusLabel.Text = "All fields must be properly populated."; | ||
} | ||
if (SpatialTransform.M.HasValue) | ||
textBoxSpatialTransformMatrix.Text = SpatialTransform.M.Value.ToString(); | ||
else | ||
textBoxSpatialTransformMatrix.Text = ""; | ||
} | ||
|
||
private static ref float GetComponent(ref Vector3 v, int index) | ||
{ | ||
switch (index) | ||
{ | ||
case 0: return ref v.X; | ||
case 1: return ref v.Y; | ||
case 2: return ref v.Z; | ||
default: throw new IndexOutOfRangeException(); | ||
}; | ||
} | ||
|
||
private Matrix4x4 Vector3sToMatrix4x4(IList<Vector3> rows) | ||
{ | ||
return new Matrix4x4( | ||
rows[0].X, rows[0].Y, rows[0].Z, 1, | ||
rows[1].X, rows[1].Y, rows[1].Z, 1, | ||
rows[2].X, rows[2].Y, rows[2].Z, 1, | ||
rows[3].X, rows[3].Y, rows[3].Z, 1); | ||
} | ||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.