Skip to content

Conversation

bparks13
Copy link
Member

To make it easier to follow the flow of logic, when pressing tab, it now follows a logical flow from left-to-right, and top-to-bottom. This is true for all existing dialogs, and this pattern should be followed for all future dialogs added.

Rhs2116
example_rhs2116

Neuropixels V1
example_npxv1

Neuropixels V2
example_npxv2

Fixes #290

@bparks13 bparks13 added this to the 0.6.1 milestone Aug 21, 2025
@bparks13 bparks13 requested a review from jonnew August 21, 2025 16:08
@bparks13 bparks13 self-assigned this Aug 21, 2025
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. The only thing I noticed is that if i keep pressing tab and reach the last editable element, the selection does not "loop" back to whatever the default first selection is. Is it possible to do this?

@jonnew
Copy link
Member

jonnew commented Aug 22, 2025

FYI, the GUI that @cjsha created for the spatial transform has the correct, looped tab behavior if you need a reference : #477

@bparks13
Copy link
Member Author

Rhs2116StimulusSequenceDialog now correctly loops from the last control to the first one. Due to WinForms default tabbing behavior, this form needs a tab handler to close the loop, otherwise the focus could go to the ChannelConfigurationDialog and get stuck there.

example_rhs2116_looping

@bparks13 bparks13 requested a review from jonnew August 22, 2025 20:07
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@bparks13 bparks13 merged commit e2216e6 into main Sep 16, 2025
8 checks passed
@bparks13 bparks13 deleted the issue-290 branch September 16, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tab order of controls in dialogs is not intuitive

2 participants