ci: Configure Release-please #22
Conversation
Signed-off-by: Bence Hornák <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @bencehornak, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates Release-please into the repository, establishing an automated system for managing releases, generating changelogs, and updating version numbers based on conventional commit messages. This setup aims to standardize and streamline the release workflow, ensuring consistency and reducing manual effort for future releases.
Highlights
- Release-please Setup: Configures Release-please for automated release management, versioning, and changelog generation, mirroring the setup in the
kotlin-sdkrepository. - Configuration Files Added: Introduces
.release-please-manifest.jsonto track the project's version andrelease-please-config.jsonto define release parameters, versioning strategy, and changelog sections. - Version Markers Integration: Integrates
x-release-pleasemarkers intobuild.gradle.ktsandproviders/env-var/README.mdto enable automated version updates by Release-please. - Documentation Update: Adds a new 'Releases' section to the main
README.mdexplaining the Release-please workflow, conventional commits, and how releases are managed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
bencehornak
changed the title
There was a problem hiding this comment.
Code Review
This pull request introduces release-please to automate the release process, which is a valuable addition for project maintenance. The configuration is well-structured, adding necessary files like release-please-config.json and updating build.gradle.kts and READMEs with version placeholders. The approach aligns with the reference kotlin-sdk repository. I have one minor suggestion to improve the generated changelog's readability.
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
| allprojects { | ||
| extra["groupId"] = "dev.openfeature.kotlin.contrib" | ||
| // x-release-please-start-version | ||
| ext["version"] = "0.1.0" |
There was a problem hiding this comment.
Can the versions be managed by each artifact? I've updated Release Please to support monorepos.
| all: ${{ toJSON(steps.release.outputs) }} | ||
| paths_released: ${{ steps.release.outputs.paths_released }} | ||
|
|
||
| kotlin-release: |
There was a problem hiding this comment.
If we're publishing artifacts individually, the release itself may need to be updated. Here's how we did it in the Python contribs. Perhaps we could do something similar here.
This PR
kotlin-sdkrepositoryFollow-up Tasks
How to test
Unfortunately, it can only be tested before merge.