Skip to content

fix some memleak #13306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix some memleak #13306

wants to merge 2 commits into from

Conversation

wjjahah
Copy link

@wjjahah wjjahah commented Jun 13, 2025

avx_component module retain twice by avx_component_op_query and ompi_op_base_op_select function;
mca_base_var_register will strdup, and not free old string;
opal_patcher_base_framework not close;

avx_component module retain twice by avx_component_op_query and ompi_op_base_op_select function;
mca_base_var_register will strdup, and not free old string;
opal_patcher_base_framework not close;

Signed-off-by: wjjahah <[email protected]>
opal_common_ucx open the opal_memory_base_framework but not close;

Signed-off-by: wjjahah <[email protected]>
@wjjahah
Copy link
Author

wjjahah commented Jun 17, 2025

Hi @bosilca , this PR is waiting for workflow approval. Could you please approve it when you have a moment?

@jsquyres
Copy link
Member

@bosilca Looks like you queued up the NVIDIA job last night, but it sat in queue for 10+ hours, so I tried to cancel it. But now it seems stuck. Can you check what's happening on the NVIDIA side?

@xbw22109
Copy link
Contributor

Sorry, not directly related to the topic of this PR: Why are there queues at Nvidia? I'm having the same problem (13261), and I think 13211 is having the same problem.

@jsquyres
Copy link
Member

jsquyres commented Jun 21, 2025

@xbw22109 Sorry about this. We actually run CI at a variety of different locations -- not just on Github cloud resources (including NVIDIA). That being said, sometimes something goes wrong on these CI resources, and sometimes they need some care and feeding. That happened with NVIDIA's CI resources this past week; they fixed the issue, but we probably missed some of the pending PRs that falsely failed. I've re-queued the jobs on #13261 and #13211. Sorry for the hassle! 😦

FYI: know that you can also re-trigger CI by pushing a new commit to a PR (even if you git commit --amend and make a meaningless change to the PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants