-
Notifications
You must be signed in to change notification settings - Fork 500
[BUILD] Add rules_cc load statements #3697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[BUILD] Add rules_cc load statements #3697
Conversation
With the next major version of bazel this becomes required. This change was automated with `buildifier -r . --lint=fix`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3697 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 225 225
Lines 7273 7273
=======================================
Hits 6542 6542
Misses 731 731 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Not a bagel expert, but trusting the buildifier gods on this one :)
Seems the CI failure is not related to the PR, something related to vcpkg. cc @ThomsonTan
Approved earlier, but noticed another CI failure (
|
thanks, wdyt about dropping WORKSPACE support now? #3699 I can fix it here but it might be a reasonable time to drop anyways |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
CI failing:
|
Thanks @keith Any chance you can take a look at opentelemetry-proto 1.8.0 in BCR ? |
3 files with changes got removed. I was expecting to resolve this using the web editor, but it looks the github UI does not allow that, this is "too complex". @keith Please take a look. |
With the next major version of bazel this becomes required. This change
was automated with
buildifier -r . --lint=fix