Fix incorrect OpenAPI entries (#8) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `latitude` in POI is `number`, not `integer` * `UserComments` IDs are `integer`, not `string` * `MediaItem` IDs are `integer`, not `string`
When using oapi-codegen, I was receiving the following error: ``` error generating code for type definitions: duplicate typename 'POI' detected, can't auto-rename, please use x-go-name to specify your own name for one of them ``` Thus this adds `x-go-name: ChargePoint` at the appropriate place. It is an `x-` annotation which are generally ignored by tools that don't use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the OCM OpenAPI yaml per the discussion in #8.
One commit fixes the incorrect types.
The other commit adds an annotation that was needed for Golang bindings.
There remains whether
boundingboxquery parameter is anarrayorstring. I have not included that one-line change in this commit series.🔌 ❤️