SAI LPO attributes #2178
SAI LPO attributes #2178
Conversation
Signed-off-by: pullarao <[email protected]>
pullaraogunda
force-pushed
the
sai_lpo_attributes
branch
from
5d8e6ef to
617a6e0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| * @default empty | ||
| */ | ||
| SAI_PORT_SERDES_ATTR_REACH_MODE, | ||
|
|
There was a problem hiding this comment.
please check if this attribute is a standard one, defined in the spec and can be beneficial for all vendors. If it is vendor-specific please consider using the SAI "custom" infrastructure (#2122)
| * @flags CREATE_AND_SET | ||
| * @default empty | ||
| */ | ||
| SAI_PORT_SERDES_ATTR_RX_ECD_MLSE_STATE, |
There was a problem hiding this comment.
Please also double-check if it is a standard attribute. See my comment above
There was a problem hiding this comment.
@eddyk-nvidia MLSE is a known technique similar to existing channel equalization techniques like DFE, FFE, CTLE. Though here its being introduced in the LPO context, its not a mandatory attribute as per the LPO MSA. Its upto the user if they want to derive the extra BER improved performance that comes with MLSE being enabled. For example, NLC attribute introduced here is also optional and not mandatory but helps to remove the non linearity based on your application specific channel characteristics.
SAI port serdes attributes support for Linear Pluggable Optics (LPO)