Support for Next Hop Meta Data #2181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please resolve conflicts and add description |
komal-marvell
force-pushed
the
nexthop_meta
branch
from
32f39d4 to
dc8c13c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Jul 3, 2025
|
@ashutosh-agrawal - please help review |
inc/saiacl.h
Outdated
| * @flags CREATE_ONLY | ||
| * @default false | ||
| */ | ||
| SAI_ACL_TABLE_ATTR_FIELD_NEXT_HOP_DST_USER_META = SAI_ACL_TABLE_ATTR_FIELD_START + 0x162, |
There was a problem hiding this comment.
Do we need to include DST in the attribute name? I understand that corresponding neighbor attribute also has DST in the attribute name but port, vlan and acl attributes don't. In my opinion, DST in the attribute name is required for FDB and ROUTE objects only.
There was a problem hiding this comment.
Thank you @ashutosh-agrawal for the review. Name updated to "SAI_ACL_TABLE_ATTR_FIELD_NEXT_HOP_USER_META"
ashutosh-agrawal
approved these changes
Jul 11, 2025
Signed-off-by: Komal Shah <[email protected]>
komal-marvell
force-pushed
the
nexthop_meta
branch
from
dc8c13c to
fa3ed7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata can be assigned in the Next Hop Table and subsequently matched in ACL entries, providing increased flexibility for policy management.