-
Notifications
You must be signed in to change notification settings - Fork 46
Provide rhel9 Dockerfile for agents #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some typos in there. Several locations refer to ubi7 or ubi8 (rhel7, rhel8) and this PR says ubi9.
Also:
Wouldn't it make more sense to get straight to ubi10?
Does it make sense to go straight to 10?
@@ -0,0 +1,27 @@ | |||
FROM opendevstackorg/ods-jenkins-agent-base-ubi8:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This starts from ubi8 but the PR says ubi9.
Also, meanwhile, ubi10 is available ...
- registry.access.redhat.com/ubi10/ubi:10.0-1747220028
LABEL com.redhat.component="jenkins-agent-jdk-35-rhel7-container" \ | ||
name="openshift4/jenkins-agent-jdk-35-rhel7" \ | ||
LABEL com.redhat.component="jenkins-agent-jdk-35-rhel8-container" \ | ||
name="openshift4/jenkins-agent-jdk-35-rhel8" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This starts from ubi8 but the PR says ubi9.
Also, meanwhile, ubi10 is available ...
registry.access.redhat.com/ubi10/ubi:10.0-1747220028
@@ -0,0 +1,85 @@ | |||
FROM opendevstackorg/ods-jenkins-agent-base-ubi8:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This starts from ubi8 but the PR says ubi9.
Also, meanwhile, ubi10 is available ...
registry.access.redhat.com/ubi10/ubi:10.0-1747220028
@@ -0,0 +1,63 @@ | |||
FROM opendevstackorg/ods-jenkins-agent-base-ubi8:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This starts from ubi8 but the PR says ubi9.
Also, meanwhile, ubi10 is available ...
registry.access.redhat.com/ubi10/ubi:10.0-1747220028
FROM opendevstackorg/ods-jenkins-agent-base-ubi8:latest | ||
|
||
# Labels consumed by Red Hat build service | ||
LABEL com.redhat.component="jenkins-agent-nodejs-18-rhel7-container" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label indicates rhel7, based on rhel8, PR says rhel9, upstream has rhel10 available
@@ -0,0 +1,68 @@ | |||
FROM opendevstackorg/ods-jenkins-agent-base-ubi8:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi8 / ubi9
@@ -0,0 +1,219 @@ | |||
FROM opendevstackorg/ods-jenkins-agent-base-ubi8:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi8 / ubi9?
@@ -0,0 +1,219 @@ | |||
FROM opendevstackorg/ods-jenkins-agent-base-ubi8:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi8/ubi9?
LABEL maintainer="Erhard Wais <[email protected]>, Frank Joas <[email protected]>, Josef Hartmann <[email protected]>, Steve Taylor <[email protected]>" | ||
|
||
# Labels consumed by Red Hat build service | ||
LABEL com.redhat.component="jenkins-agent-terraform-ubi8-docker" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi8/ubi9?
|
||
# Labels consumed by Red Hat build service | ||
LABEL com.redhat.component="jenkins-agent-terraform-ubi8-docker" \ | ||
name="openshift/jenkins-agent-terraform-ubi8" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi8/ubi9?
Hi @serverhorror Jenkins agents are based on the Redhat images. They have only provided hrel 8 images until recently when thy provided rhel 9 ones. So far there is no rhel10 variant that they provide: https://catalog.redhat.com/search?gs&q=jenkins%20Container%20image&searchType=containers Aditionally, this image needs redhat account for pulling so it cannot be used in CI/CD here in GitHub to build the agents and upload them into Dockerhub. The only ones available are rhel8 variants in Quay registry and they have not been updated for over a year already. You can see the issues here: |
Depends on opendevstack/ods-core#1336
TEST: