-
Notifications
You must be signed in to change notification settings - Fork 165
fix: Disable Begin Course button if course is closed by prerequisites #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Disable Begin Course button if course is closed by prerequisites #716
Conversation
Thanks for the pull request, @Lunyachek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 97.60% 97.62% +0.02%
==========================================
Files 152 152
Lines 1334 1347 +13
Branches 231 244 +13
==========================================
+ Hits 1302 1315 +13
Misses 31 31
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@Lunyachek Thank you for your contribution! Since it is a user-facing change, you will need to get 👍 for it from a product reviewer before engineering review can start. @openedx/openedx-product-managers Please have a look at this PR. It is a fast-track change that follows the workflow for bug fixes described here. (= There is no roadmap issue for the change. Product review can happen right here on the PR and/or the corresponding bug report.) |
Reply from Sarina: #684 (comment) |
Related to this issue - #684
What was done?
Why it matters
Previously, the Begin Course button could remain active even if a course was locked by unmet prerequisites. This misled users: the button was clickable, but access was blocked by the LMS after navigation.
Now, the restriction is surfaced directly in the UI, improving UX and preventing unnecessary transitions.
Result
2025-09-11.11.40.52.mov