Use curve to digitize Polylines/Polygons #5842

qsavoye · 2024-11-21T15:39:10Z

Use curve to digitize Polylines/Polygons

Active Curve mode during Digitization of a Polygon
Add a first vertex to define the center point of the arc
Add a second vertex to stop the arc

Precision of the final arc can be set in QField Parameters page (slider)

m-kuhn · 2024-11-21T15:59:03Z

src/qml/qgismobileapp.qml

+          height: visible ? 40 : 0
+          padding: 2
+          round: true
+          visible: dashBoard.activeLayer && (dashBoard.activeLayer.geometryType() === Qgis.GeometryType.Polygon || dashBoard.activeLayer.geometryType() === Qgis.GeometryType.Line)


I think we want this to be dependent on QgsWkbTypes.isCurvedType()

In my example , my layer is not a curve type at all and i use QgsCompoundCurve::curveToLine function to set geometry drawn into my none curved layer. This helps me to drawn faster instead of set vertex by vertex.

But you are right i am not taking into account the possibility to set directly the qgscompoundcurve geometry into the new feature.

How do you think ?

Interesting, I was mostly seeing this in the context of surveying / cadastre, where curves are often a requirement. My main motivation here would be to keep the interface as light as possible and ask users to have a curve layer if they want this feature. What do you think?

I am using it to draw underground maps, such as caves or old quarries. My polygon layer corresponds to some galleries and i no need to have a specific curved layer but some times digitizing arcs like in qgis help me.

Maybe we can allow it only for curved layer (QgsWkbTypes.isCurvedType()) or for advanced digitizing user ( which could be set in settings).

Tell me what you think ?

Sorry for the delay, i had some stuff to do last week.

Interesting job you have!

I'd be interested to hear @nirvn's point of view

@m-kuhn , @qsavoye , hey there, sorry for the delay in chipping in.

I do think the feature is useful; I would indeed prefer if this option was only visible for curved type layers, I feel that'd be a good way to enable this while not cluttering UI by limiting to an explicit intent by the user / project manager.

@m-kuhn @nirvn,
Ok with your reviews.
I will patch it for only allowing layer with QgsWkbTypes.isCurvedType() as soon as I have time

nirvn · 2024-12-15T09:36:17Z

src/qml/DigitizingToolbar.qml

@@ -242,7 +242,19 @@ QfVisibilityFadingRow {
      if (Number(rubberbandModel.geometryType) === Qgis.GeometryType.Point || Number(rubberbandModel.geometryType) === Qgis.GeometryType.Null) {
        confirm();
      } else {
-        addVertex();
+        if (settings.valueBool("/QField/Digitizing/CurveEdition", false) == true) {


I think we need an additional check here to avoid curved edition when people are freehand drawing, otherwise worlds will collide.

m-kuhn · 2024-12-25T07:14:31Z

@9ls1 I noted you added a 👍 to this, do you have a specific use case in mind for which this would be interesting?

9ls1 · 2024-12-25T11:04:33Z

@m-kuhn No, just in general thinking about saving time digitizing shapes like the one shown here and curved roads.

…rom-qfield-team

…e-digitize-feature

nirvn · 2025-03-30T06:36:07Z

@qsavoye , you have not been forgotten :) I'll review this in the coming day. Thanks for your patience.

nirvn · 2025-04-07T08:28:26Z

src/core/rubberbandmodel.h

@@ -197,14 +215,19 @@ class QFIELD_CORE_EXPORT RubberbandModel : public QObject
    void measureValueChanged();

  private:
-    QVector<QgsPoint> mPointList;
+    QgsCompoundCurve mCompoundCurve;


I'm a little bit worried of the extra cost of moving from a simple QVector to a QgsAbstractGeometry-based curve here. I am wondering whether we should keep both the fast point list vector (used by our tracking system among other things), and have the mCompoundCurve as an alternative path for curved geometries.

nirvn · 2025-04-07T08:29:58Z

src/core/rubberbandmodel.cpp

@@ -60,7 +72,7 @@ QgsPointSequence RubberbandModel::pointSequence( const QgsCoordinateReferenceSys
  QgsPointSequence sequence;
  QgsCoordinateTransform ct( mCrs, crs, QgsProject::instance()->transformContext() );

-  for ( const QgsPoint &pt : mPointList )
+  for ( const QgsPoint &pt : vertices() )


Let's do that instead.

Suggested change

for ( const QgsPoint &pt : vertices() )

const QVector<QgsPoint> vertices = vertices();

for ( const QgsPoint &pt : vertices )

nirvn · 2025-04-07T08:30:06Z

src/core/rubberbandmodel.cpp

@@ -97,7 +109,7 @@ QVector<QgsPointXY> RubberbandModel::flatPointSequence( const QgsCoordinateRefer

  QgsCoordinateTransform ct( mCrs, crs, QgsProject::instance()->transformContext() );

-  for ( const QgsPoint &pt : mPointList )
+  for ( const QgsPoint &pt : vertices() )


nirvn · 2025-04-07T08:40:22Z

src/core/featuremodel.cpp

@@ -779,6 +779,10 @@ void FeatureModel::applyGeometry()
      geometry = deduplicatedGeometry;
  }

+  if ( QgsWkbTypes::isCurvedType( layer()->wkbType() ) == true )


You'll need more than this to preserve the curves here. You'll need to edit the Geometry::asQgsGeometry (

QField/src/core/geometry.cpp

Line 27 in f0e0aeb

QgsGeometry Geometry::asQgsGeometry() const

) function to preserve curves passed on by the rubberband when appropriate.

nirvn · 2025-04-07T08:42:50Z

src/core/utils/layerutils.cpp

@@ -383,3 +383,11 @@ FeatureIterator LayerUtils::createFeatureIteratorFromExpression( QgsVectorLayer
  const QgsFeatureRequest request = QgsFeatureRequest( QgsExpression( expression ) );
  return FeatureIterator( layer, request );
 }
+
+bool LayerUtils::isCurvedGeometry( QgsVectorLayer *layer )


Note to self: we should make the QgswkbTypes' isCurvedType Q_INVOKABLE upstream, that way we don't need an extra utils function.

That being said, I think I'd rather have that in the geometryutils, and on the QML side of things you can call a vector layer's wkbType() function (it's invokable).

@nirvn
Do you prefer : make a patch when compiling qgis to modify QgsWkbTypes.h and erase what I did on LayerUtils or move the method into GeometryUtils ?

@qsavoye , I'd love for you to submit a patch in QGIS upstream (we're 5 days away from 3.44 release), then we can update QField to 3.44 when released and we'll be able to make sure of that newly-made invokable function.

@qsavoye , I've taken care of upstream here: qgis/QGIS#62306

nirvn · 2025-04-07T08:43:33Z

src/core/vertexmodel.cpp

@@ -188,6 +188,11 @@ void VertexModel::refreshGeometry()
    }
  }

+  if ( QgsWkbTypes::isCurvedType( geom.wkbType() ) == true )
+  {
+    geom.convertToStraightSegment();


I'm worried about this change, did you give it a try? Was that giving you usable scenarios?

nirvn · 2025-04-17T12:48:27Z

@qsavoye , are you planning to work on this further?

qsavoye · 2025-04-17T13:52:58Z

@qsavoye , are you planning to work on this further?

@nirvn , yes but i will be unavailable to work on it for at least a month :(

nirvn · 2025-04-17T15:14:29Z

@qsavoye , no problem, take your time. You're contributions are appreciated, just glad to hear you're planning to come back to it :)

Quentin Savoye added 4 commits November 20, 2024 14:12

Rubberbound replace vector of qgspoint by qgscompoundcurve

d6c3dcb

add circular string to rubberbound during digitizing

552ae46

add curve to reshape, split, erase, fill

723d9a8

reset rubberband on confirm or cancel

a7ad6d7

m-kuhn reviewed Nov 21, 2024

View reviewed changes

nirvn reviewed Dec 15, 2024

View reviewed changes

Quentin Savoye added 4 commits February 21, 2025 10:58

set curve edition only for curve geometry

265d605

Do not use during freehand digitizing

1e31c5c

Merge commit '6573c1ddd93ce7d84f5f36d5f6b0148de33d337b' into remark-f…

fda9ab1

…rom-qfield-team

Merge commit 'fda9ab1fc75480468c877309b6e2f0857a620e11' into add-curv…

f0e0aeb

…e-digitize-feature

qsavoye requested review from nirvn and m-kuhn March 25, 2025 16:30

nirvn added the ENHANCEMENT label Mar 30, 2025

nirvn reviewed Apr 7, 2025

View reviewed changes

	for ( const QgsPoint &pt : vertices() )
	const QVector<QgsPoint> vertices = vertices();
	for ( const QgsPoint &pt : vertices )

Uh oh!

Use curve to digitize Polylines/Polygons #5842

Are you sure you want to change the base?

Use curve to digitize Polylines/Polygons #5842

Uh oh!

Conversation

qsavoye commented Nov 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

m-kuhn commented Dec 25, 2024

Uh oh!

9ls1 commented Dec 25, 2024

Uh oh!

nirvn commented Mar 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nirvn commented Apr 17, 2025

Uh oh!

qsavoye commented Apr 17, 2025

Uh oh!

nirvn commented Apr 17, 2025

Uh oh!

Uh oh!