Replace DRF wirth Ninja #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oreilles
force-pushed
the
ninja2
branch
2 times, most recently
from
aea0383 to
9f739ac
Compare
suricactus
reviewed
Jul 30, 2025
django_oapif/__init__.py
Outdated
Comment on lines
1
to
2
| from . import permissions | ||
| from .api import OAPIF |
There was a problem hiding this comment.
Shall we stick only to one type of imports? I see almost everywhere else we use absolute imports, which are slightly more preferrable.
There was a problem hiding this comment.
Sure, I think we can even remove the re-export of permissions from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.