App pkg same app image layout #25663
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
alexeysemenyukoracle
force-pushed
the
app-pkg-same-app-image-layout
branch
5 times, most recently
from
5477ef1 to
322614c
Compare
alexeysemenyukoracle
force-pushed
the
app-pkg-same-app-image-layout
branch
3 times, most recently
from
366a1ad to
0af3df3
Compare
… IDE). Add AppImageLayout.map(), AppImageLayout.unresolve(), AppImageLayout.emptyRootDirectory() and AppImageLayout.isResolved(). Fix AppImageLayout javadoc. Add relevant unit tests. Add a way to iterate over configured tasks in packaging pipeline builder. Add unit tests for LinuxApplicationLayout and MacApplicationLayout
…sApplicationLayout() and static BuildEnv.withAppImageLayout(). Add tests for BuildEnv
…Directory() was added. Support using an external app image with a custom app image layout. Add ApplicationBuilder.overrideAppImageLayout(). Remove Package.packageLayout() and Package.asPackageApplicationLayout(). Create Linux and Mac packages with app image layout configured for packaging making PackagingPipeline.Builder.appImageLayoutForPackaging() redundant. Simplify PackagingPipeline. It always builds with application's app image layout. Don't wrap RuntimeException-s in PackagerException-s. Merge PackagingPipeline.appContextMapper and PackagingPipeline.pkgContextMapper into PackagingPipeline.contextMapper. Remove PackagingPipeline.Builder.appImageLayoutForPackaging(). Add MacPackage.guessRuntimeLayout()
…stom runtime image layout for application in FromParams.createApplicationBuilder(). Set correct layout for predefined runtime image on macosx
…ts. Fix tool validator and better test coverage.
… Created SystemEnvironment interface to hold system properties - paths to build tools. Share a single instance of LinuxSystemEnvironment between BED and RPM bundlers. This is to make `dpkg -s coreutils` command run only once and not twice for each bundler
alexeysemenyukoracle
force-pushed
the
app-pkg-same-app-image-layout
branch
from
0af3df3 to
b752d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress
Error
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25663/head:pull/25663$ git checkout pull/25663Update a local copy of the PR:
$ git checkout pull/25663$ git pull https://git.openjdk.org/jdk.git pull/25663/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25663View PR using the GUI difftool:
$ git pr show -t 25663Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25663.diff