-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8357591: Re-enable CDS test cases for jvmci after JDK-8345826 #25667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8357591: Re-enable CDS test cases for jvmci after JDK-8345826 #25667
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it here too (used by aotCode/ tests)
https://github.com/openjdk/jdk/blob/master/test/jtreg-ext/requires/VMProps.java#L482
Actually no. We do not want to run these tests with Graal for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Thanks @vnkozlov @dholmes-ora for the review |
Going to push as commit d186dac.
Your commit was automatically rebased without conflicts. |
CDS tests should be re-enabled for graal. I tested with hs-tier9-graal.js, hs-tier11-graal.js and hs-tier12-graal.js.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25667/head:pull/25667
$ git checkout pull/25667
Update a local copy of the PR:
$ git checkout pull/25667
$ git pull https://git.openjdk.org/jdk.git pull/25667/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25667
View PR using the GUI difftool:
$ git pr show -t 25667
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25667.diff
Using Webrev
Link to Webrev Comment