8358749: Fix input checks in Vector API intrinsics

[shipilev]

We have been carrying this patch in Leyden/premain for a while: openjdk/leyden@7faed7f. I believe it deserves to be in mainline. I polished it a little further.

It is mostly a cleanup, but there are also new checks, on the paths where we do take constants off the arguments. In those cases, I believe the alternative is compiler SEGV-ing.

Additional testing:

• Linux x86_64 server fastdebug, hotspot_vector_1 hotspot_vector_2
• Linux x86_64 server fastdebug, jdk_vector

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358749: Fix input checks in Vector API intrinsics (Enhancement - P4)

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Sandhya Viswanathan (@sviswa7 - Reviewer)

Contributors

• Vladimir Ivanov <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25673/head:pull/25673
$ git checkout pull/25673

Update a local copy of the PR:
$ git checkout pull/25673
$ git pull https://git.openjdk.org/jdk.git pull/25673/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25673

View PR using the GUI difftool:
$ git pr show -t 25673

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25673.diff

Using Webrev

Link to Webrev Comment

[shipilev]

/contributor add @iwanowww

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358749: Fix input checks in Vector API intrinsics

Co-authored-by: Vladimir Ivanov <[email protected]>
Reviewed-by: vlivanov, sviswanathan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• d735255: 8345414: Google CAInterop test failures
• d024f58: 8358809: Improve link to stdin.encoding from java.lang.IO
• 026975a: 8358721: Update JCov for class file version 70
• ... and 5 more: https://git.openjdk.org/jdk/compare/bb2611ad43a2feaebc2246fdbac2179a40115d67...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev
Contributor Vladimir Ivanov <[email protected]> successfully added.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c7820694)

[iwanowww]

Looks good.

Thanks for taking care of upstreaming it.

[sviswa7]

Looks good to me as well.

[ExE-Boss]

Also note that the implementation of Utils.isNonCapturingLambda(…) is wrong when the jdk.internal.lambda.disableEagerInitialization system property is set to "true", as that causes lambda classes to have one static final field:

jdk/src/java.base/share/classes/jdk/internal/vm/vector/Utils.java

Lines 36 to 38 in d735255

	public static boolean isNonCapturingLambda(Object o) {
	return o.getClass().getDeclaredFields().length == 0;
	}

jdk/src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java

Lines 365 to 372 in d735255

	private void generateClassInitializer(ClassBuilder clb) {
	ClassDesc lambdaTypeDescriptor = classDesc(factoryType.returnType());
	// Generate the static final field that holds the lambda singleton
	clb.withField(LAMBDA_INSTANCE_FIELD, lambdaTypeDescriptor, ACC_PRIVATE | ACC_STATIC | ACC_FINAL);
	// Instantiate the lambda and store it to the static final field
	clb.withMethodBody(CLASS_INIT_NAME, MTD_void, ACC_STATIC, new Consumer<>() {