8368821: Test java/net/httpclient/http3/GetHTTP3Test.java intermittently fails with java.io.IOException: QUIC endpoint closed

[jaikiran]

Can I please get a review of this test-only change which addresses intermittent failures in GetHTTP3Test and PostHTTP3Test?

As noted in https://bugs.openjdk.org/browse/JDK-8368821, these two tests have been reported to fail intermittently, especially when the host on which it runs is under heavy resource usage or when run with JVM options like -Xcomp.

The commit in this PR removes the connection timeout that was enforced on the connection attempts by the test. As far as I can see, they aren't necessary for what this test is testing. The change also updates a few other places in this test which had specific values for timeouts when checking if the HttpClient had shutdown. These places have been updated to take into account the timeout factor when computing the timeout.

The changes have been verified by Matthias and SendaoYan who originally reported these issues. I will run this change in our CI too before integrating.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368821: Test java/net/httpclient/http3/GetHTTP3Test.java intermittently fails with java.io.IOException: QUIC endpoint closed (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27619/head:pull/27619
$ git checkout pull/27619

Update a local copy of the PR:
$ git checkout pull/27619
$ git pull https://git.openjdk.org/jdk.git pull/27619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27619

View PR using the GUI difftool:
$ git pr show -t 27619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27619.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368821: Test java/net/httpclient/http3/GetHTTP3Test.java intermittently fails with java.io.IOException: QUIC endpoint closed

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 134b63f: 8322174: RISC-V: C2 VectorizedHashCode RVV Version
• 2e78396: 8369037: Identify owning method for MethodData and MethodCounters in AOT map output
• ebb6fd7: 8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (55981a8e)

[dfuch]

The proposed changes look good to me. I agree that the connection timeout is not needed for the purpose of the test. It might have been added to fail the test earlier while working on the implementation and running the test locally, but if it causes trouble in higher tiers I believe we can remove it safely.

[jaikiran]

Thank you Daniel for the review. tier testing with these changes in our CI came back fine.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 76dba20.
Since your change was applied there have been 13 commits pushed to the master branch:

• c3fbbfa: 8369027: Apply java.io.Serial annotations in java.scripting
• e6868c6: 8369138: New test compiler/loopstripmining/MissingStoreAfterOuterStripMinedLoop.java fails
• 837f634: 8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs
• ... and 10 more: https://git.openjdk.org/jdk/compare/3790965df3e7cba3b9792b8719d1e2ead046da15...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 76dba20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.