8369129: Raster createPackedRaster methods specification clean up #27627
+585
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the specification of Raster.createPackedRaster(..) methods and also the implementation of these to explicitly check the specified conditions rather than relying on them being passed up from some other API.
Also one each of the createInterleavedRaster(..) and createBandedRaster(..) methods have an update
createInterleavedRaster(...) to address that even if WxH does not exceed Integer.MAX_VALUE, the storage needed still might.
createBandedRaster(..) to address
There's an unfortunate oddity with this that of bankIndices is null it specifies and throws AIOBE, but I didn't think it worth changing either of these to make them consistent.
The existing CreateRasterExceptionTest.java is updated to verify all these assertions.
In almost all cases the behaviour is unchanged, it is just now properly specified and verified up front.
There are only 2 sub-tests which would fail on JDK 25
The test can also be run (and pass) there without this fix because it explicitly handles those 2 cases which are reasonable behavioral changes
The CSR is now ready for review https://bugs.openjdk.org/browse/JDK-8369131
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27627/head:pull/27627
$ git checkout pull/27627
Update a local copy of the PR:
$ git checkout pull/27627
$ git pull https://git.openjdk.org/jdk.git pull/27627/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27627
View PR using the GUI difftool:
$ git pr show -t 27627
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27627.diff
Using Webrev
Link to Webrev Comment