Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 27, 2025

Hi all,

The test gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java use the class SurvivorAlignmentTestMain and AlignmentHelper which located in the same directory with tested class. I think we should build the depencied class explictly to avoid jtreg report javac compile failure.

This test was removed by https://bugs.openjdk.org/browse/JDK-8255298, So this test only effect jdk11u.

Change has been verified locally, test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366221 needs maintainer approval

Issue

  • JDK-8366221: [11u] TestPromotionFromSurvivorToTenuredAfterMinorGC.java javac build fails (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3079/head:pull/3079
$ git checkout pull/3079

Update a local copy of the PR:
$ git checkout pull/3079
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3079/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3079

View PR using the GUI difftool:
$ git pr show -t 3079

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3079.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 27, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 27, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant