Skip to content

fix: Link for connect button #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

fix: Link for connect button #245

merged 1 commit into from
Aug 18, 2025

Conversation

andreaskienle
Copy link
Contributor

This PR fixes the link used by the Connect button when multiple contexts are present.

We previously removed the context from the URL (see #206), but this instance was missed.

@Copilot Copilot AI review requested due to automatic review settings August 18, 2025 09:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the URL construction for the Connect button by removing the context parameter from the path. This aligns with a previous change that removed context from URLs throughout the application but was missed in this specific component.

  • Removes /context/${context.name} from the data-target URL path
  • Ensures consistency with the URL structure established in PR #206

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andreaskienle andreaskienle merged commit c08fa88 into main Aug 18, 2025
5 checks passed
@andreaskienle andreaskienle deleted the fix-navigation branch August 18, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants