Apply changes from @keskami to oui-main #1498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Longo <[email protected]>
TomasLongo
requested review from
AMoo-Miki,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
virajsanghvi,
ruanyl and
d-buckner
as code owners
|
Hey @TomasLongo we are planning on completely refactoring the table component soon and as a result might not maintain this component going forward. Right now we are trying to avoid making any changes to the current table component since we dont want to affect any existing usecases. Since this change has more changes than what i was hoping to quickly review and push in, would it be okay to table this until one of the maintainers gets some time to review it or we introduce the new table? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
This PR is, basically, a duplicate of #1133. The original PR seems to be mergeable. However, there has been no activity for 1. years now and the PR needed to be rebased on main.
This is my attempt to drive this PR forward.
@joshuarrrr
@keskami
Description
Adds tooltip to DataGrid header cell
Issues Resolved
Fixes #809
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.