Skip to content

Enable navigating grid headers by tab-key #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TomasLongo
Copy link

Description

Make grid headers navigable via tab keys

Issues Resolved

Resolves: #1501

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TomasLongo
Copy link
Author

Hey everyone.

I'm new to the project and also not an expert in UI development. So, chances are, that my changes do not take into account possible impacts on other parts of the ui.

The change in it's current form is simple. but most likely not complete. The code surrounding those changes makes me wonder:

  • Why have header cells been taken out of the tab index at all? Especially, because the same function, while setting tabIndex to -1 also sets an attribute data-ouigrid-tab-managed to true. Seen from my current position, this contradicts the removal from the tab index (this conclusino is most certainly wrong)

To be complete, ControlHeaders should also be tabbable. However, I wasn't able to make it work just like I managed to do it with the normal headers. This might be done in a separate step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [a11ty] Navigate data-grid headers with keyboard
1 participant