Skip to content

ODC-7795: Move Setup GitHub App page to dynamic plugin #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lokanandaprabhu
Copy link
Member

Description:

Migrated Setup GitHub App page from static plugin to console dynamic plugin

Tests:

image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 29, 2025

@lokanandaprabhu: This pull request references ODC-7795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Description:

Migrated Setup GitHub App page from static plugin to console dynamic plugin

Tests:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lokanandaprabhu
Copy link
Member Author

/cc @vikram-raj @sanketpathak

@openshift-ci openshift-ci bot requested a review from vikram-raj May 29, 2025 10:35
Copy link
Contributor

openshift-ci bot commented May 29, 2025

@lokanandaprabhu: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vikram-raj @sanketpathak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lokanandaprabhu lokanandaprabhu force-pushed the feature/adding-setup-github-app branch from 4cce031 to 16d8426 Compare June 18, 2025 14:28
@lokanandaprabhu
Copy link
Member Author

Rebased the PR.

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vikram-raj
Copy link
Member

/retest

@vikram-raj vikram-raj merged commit 10a26e5 into openshift-pipelines:main Jun 24, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants