[MIRRORED] DO NOT MERGE: fix(bitbucketdatacenter): ignore branch deletion events in ParsePayload #2130
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
zakisk
force-pushed
the
test-pr-2126-infernus01
branch
from
f9f5a41 to
7f614d2
Compare
chmouel
force-pushed
the
test-pr-2126-infernus01
branch
from
7f614d2 to
f9f5a41
Compare
zakisk
force-pushed
the
test-pr-2126-infernus01
branch
2 times, most recently
from
b1fd690 to
6618555
Compare
When a branch is deleted in Bitbucket Data Center, the repo:refs_changed webhook sends a change with toHash set to all-zeros. Previously, Pipelines as Code treated this like a push event, which caused errors when trying to validate a missing commit. This patch detects and ignores such events early in ParsePayload. Fixes openshift-pipelines#2035
chmouel
force-pushed
the
test-pr-2126-infernus01
branch
from
6618555 to
bd8c88e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors #2126 to run E2E tests. Original author: @infernus01