-
Notifications
You must be signed in to change notification settings - Fork 10
[kubevirtci]: refactor cluster-sync target to work with kubevirtci #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Igor Bezukh <[email protected]>
Signed-off-by: Igor Bezukh <[email protected]>
this file intedned for the ephemeral local cluster setup therefore it doesn't impose any security breach by exposing it in the repo. Signed-off-by: Igor Bezukh <[email protected]>
added scripts in hack directory to comply with kubevirtci dependencies Signed-off-by: Igor Bezukh <[email protected]>
kubevirt deployment moved to cluster-sync. sync.sh clean.sh install.sh are now working with kubevirtci. KUBEVIRT_RELEASE is now defined in common.sh fixed default image url for make manifests its now the internal registry URL of kubevirtci. Signed-off-by: Igor Bezukh <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I added a few small comments. Also, I'll create an issue to automatically update the builder image as a post-submit job when it's changed.
@@ -44,5 +44,6 @@ VENDOR_DIR=${WASP_DIR}/vendor | |||
ARCHITECTURE="${BUILD_ARCH:-$(uname -m)}" | |||
HOST_ARCHITECTURE="$(uname -m)" | |||
WASP_CRI="$(determine_wasp_bin)" | |||
KUBEVIRT_RELEASE=${KUBEVIRT_RELEASE:-"latest_nightly"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about changing this the latest_stable i think that it's good enough since wasp is not coupled with kubevirt.
There are some leftovers on ./cluster-up dir |
Signed-off-by: Igor Bezukh [email protected]
Depends on #84
cluster-sync now deploys kubevirt. KUBEVIRT_RELEASE is now defined in common.sh
cluster-sync scripts are now synced with the kubevirtci repo