-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-15543#Improved environment variable parsing for ImagePaths #100338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lpettyjo
wants to merge
1
commit into
openshift:main
Choose a base branch
from
lpettyjo:OSDOCS-15543
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,6 +96,20 @@ local: | |
path: /test/podinfo-5.0.0.tar.gz | ||
---- | ||
|
||
|`mirror.helm.local.charts.imagePaths` | ||
|The custom path of a container image inside of the local helm chart. | ||
+ | ||
[NOTE] | ||
==== | ||
`oc-mirror` detects and mirrors container images from the helm chart by searching well-known paths. You can also specify custom paths using this field. | ||
==== | ||
+ | ||
[NOTE] | ||
==== | ||
Operand images, dynamically deployed by operator controllers at runtime, are typically referenced by environment variables within the controller's Deployment template. Before {product-title} 4.20, while `oc-mirror` could access these environment variables, it attempted to mirror all values, including non-image references, for example, log levels, leading to failures. Now {product-title} identifies and mirrors only the container images referenced in these environment variables. | ||
==== | ||
|Array of string. For example: `"- {.spec.template.spec.custom[*].image}"`. | ||
|
||
|`mirror.helm.local.name` | ||
|The name of the local helm chart to mirror. | ||
|String. For example: `podinfo`. | ||
|
@@ -143,7 +157,12 @@ repositories: | |
==== | ||
`oc-mirror` detects and mirrors container images from the helm chart by searching well-known paths. You can also specify custom paths using this field. | ||
==== | ||
|Array of string. For example: `"- {.spec.template.spec.custom[*].image}"`. | ||
+ | ||
[NOTE] | ||
==== | ||
Operand images, dynamically deployed by operator controllers at runtime, are typically referenced by environment variables within the controller's Deployment template. Before {product-title} 4.20, while `oc-mirror` could access these environment variables, it attempted to mirror all values, including non-image references, for example, log levels, leading to failures. Now {product-title} identifies and mirrors only the container images referenced in these environment variables. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above |
||
==== | ||
|Array of string. For example: `"- {.spec.template.spec.custom[*].image}"`. | ||
endif::microshift[] | ||
|
||
|`mirror.operators` | ||
|
@@ -508,4 +527,4 @@ The default is `ocp` | |
|Boolean | ||
The default value is `false` | ||
endif::microshift[] | ||
|=== | ||
|=== |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now
usage guidelines: https://redhat-documentation.github.io/supplementary-style-guide/#now