Skip to content

OSDOCS-14876#RN Azure #94390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brendan-daly-red-hat
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat commented Jun 6, 2025

Version:
4.19

Issue:
https://issues.redhat.com/browse/OSDOCS-14876

Link to docs preview:
Enabling boot diagnostics collection during installation on Microsoft Azure

QE review:

  • QE has approved this change.

Additional information:
This is the feature PR: #93547

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 6, 2025

🤖 Tue Jun 10 15:30:13 - Prow CI generated the docs preview:

https://94390--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-19-release-notes.html

@@ -472,6 +473,13 @@ With this release, you can install a cluster on {vmw-first} with multiple storag

For more information, see xref:../installing/installing_vsphere/installation-config-parameters-vsphere.html#installation-configuration-parameters-optional-vsphere_installation-config-parameters-vsphere[Optional vSphere configuration parameters].

[id="ocp-4-19-installation-and-update-azure-boot-diagnostics_{context}"]
==== Enabling boot diagnostics collection during installation for {azure-first}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== Enabling boot diagnostics collection during installation for {azure-first}
==== Enabling boot diagnostics collection during installation on {azure-first}

[id="ocp-4-19-installation-and-update-azure-boot-diagnostics_{context}"]
==== Enabling boot diagnostics collection during installation for {azure-first}

With this release, you can configure {azure-first} to enable boot diagnostics collection when you install a cluster. You can set the `bootDiagnostics` parameter in the `install-config.yaml` file for compute machines, for control plane machines, or for all machines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With this release, you can configure {azure-first} to enable boot diagnostics collection when you install a cluster. You can set the `bootDiagnostics` parameter in the `install-config.yaml` file for compute machines, for control plane machines, or for all machines.
With this release, you can enable boot diagnostics collection when you install a cluster on {azure-first}. You can set the `bootDiagnostics` parameter in the `install-config.yaml` file for compute machines, for control plane machines, or for all machines.

@brendan-daly-red-hat
Copy link
Contributor Author

/retest

@brendan-daly-red-hat
Copy link
Contributor Author

@jinyunma, PTAL

@jinyunma
Copy link

jinyunma commented Jun 9, 2025

LGTM

@brendan-daly-red-hat
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 10, 2025
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 10, 2025
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit for your consideration, otherwise, LGTM!


With this release, you can enable boot diagnostics collection when you install a cluster on {azure-first}. Boot diagnostics is a debugging feature for {azure-short} virtual machines (VMs) to identify VM boot failures. You can set the `bootDiagnostics` parameter in the `install-config.yaml` file for compute machines, for control plane machines, or for all machines.

For more information, see xref:../installing/installing_azure/installation-config-parameters-azure.html#installation-configuration-parameters-additional-azure_installation-config-parameters-azure[Additional {azure-short} configuration parameters].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information, see xref:../installing/installing_azure/installation-config-parameters-azure.html#installation-configuration-parameters-additional-azure_installation-config-parameters-azure[Additional {azure-short} configuration parameters].
For more information, see xref:../installing/installing_azure/installation-config-parameters-azure.html#installation-configuration-parameters-additional-azure_installation-config-parameters-azure.adoc[Additional {azure-short} configuration parameters].

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale says "Use .adoc instead of .html in xrefs"

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 10, 2025
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2025
Copy link

openshift-ci bot commented Jun 10, 2025

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brendan-daly-red-hat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 10, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 10, 2025
@jeana-redhat jeana-redhat added this to the Planned for 4.19 GA milestone Jun 10, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 10, 2025
@jeana-redhat jeana-redhat merged commit 171cb83 into openshift:enterprise-4.19 Jun 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants