-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14876#RN Azure #94390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-14876#RN Azure #94390
Conversation
🤖 Tue Jun 10 15:30:13 - Prow CI generated the docs preview: |
@@ -472,6 +473,13 @@ With this release, you can install a cluster on {vmw-first} with multiple storag | |||
|
|||
For more information, see xref:../installing/installing_vsphere/installation-config-parameters-vsphere.html#installation-configuration-parameters-optional-vsphere_installation-config-parameters-vsphere[Optional vSphere configuration parameters]. | |||
|
|||
[id="ocp-4-19-installation-and-update-azure-boot-diagnostics_{context}"] | |||
==== Enabling boot diagnostics collection during installation for {azure-first} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
==== Enabling boot diagnostics collection during installation for {azure-first} | |
==== Enabling boot diagnostics collection during installation on {azure-first} |
[id="ocp-4-19-installation-and-update-azure-boot-diagnostics_{context}"] | ||
==== Enabling boot diagnostics collection during installation for {azure-first} | ||
|
||
With this release, you can configure {azure-first} to enable boot diagnostics collection when you install a cluster. You can set the `bootDiagnostics` parameter in the `install-config.yaml` file for compute machines, for control plane machines, or for all machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this release, you can configure {azure-first} to enable boot diagnostics collection when you install a cluster. You can set the `bootDiagnostics` parameter in the `install-config.yaml` file for compute machines, for control plane machines, or for all machines. | |
With this release, you can enable boot diagnostics collection when you install a cluster on {azure-first}. You can set the `bootDiagnostics` parameter in the `install-config.yaml` file for compute machines, for control plane machines, or for all machines. |
c5df8e4
to
da03971
Compare
/retest |
@jinyunma, PTAL |
LGTM |
/label peer-review-needed |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit for your consideration, otherwise, LGTM!
|
||
With this release, you can enable boot diagnostics collection when you install a cluster on {azure-first}. Boot diagnostics is a debugging feature for {azure-short} virtual machines (VMs) to identify VM boot failures. You can set the `bootDiagnostics` parameter in the `install-config.yaml` file for compute machines, for control plane machines, or for all machines. | ||
|
||
For more information, see xref:../installing/installing_azure/installation-config-parameters-azure.html#installation-configuration-parameters-additional-azure_installation-config-parameters-azure[Additional {azure-short} configuration parameters]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information, see xref:../installing/installing_azure/installation-config-parameters-azure.html#installation-configuration-parameters-additional-azure_installation-config-parameters-azure[Additional {azure-short} configuration parameters]. | |
For more information, see xref:../installing/installing_azure/installation-config-parameters-azure.html#installation-configuration-parameters-additional-azure_installation-config-parameters-azure.adoc[Additional {azure-short} configuration parameters]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vale says "Use .adoc instead of .html in xrefs"
/label peer-review-done |
da03971
to
335daf2
Compare
335daf2
to
d2690a3
Compare
@brendan-daly-red-hat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/remove-label merge-review-in-progress
/remove-label merge-review-needed
Version:
4.19
Issue:
https://issues.redhat.com/browse/OSDOCS-14876
Link to docs preview:
Enabling boot diagnostics collection during installation on Microsoft Azure
QE review:
Additional information:
This is the feature PR: #93547