Skip to content

[RHACS] [Docs] ROX-27682: Adding updates to Compliance reporting documentation #94394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rhacs-docs-main
Choose a base branch
from

Conversation

agantony
Copy link
Contributor

@agantony agantony commented Jun 6, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2025

@agantony: This pull request references ROX-27682 which is a valid jira issue.

In response to this:

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/ROX-27682

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2025
@agantony agantony added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 labels Jun 6, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2025
@agantony agantony force-pushed the ROX27682-rhacs-docs-main branch from 30ba109 to 5751a77 Compare June 6, 2025 15:51
@agantony agantony added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 6, 2025
Copy link

openshift-ci bot commented Jun 6, 2025

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2025

@agantony: This pull request references ROX-27682 which is a valid jira issue.

In response to this:

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/ROX-27682

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lpettyjo lpettyjo self-requested a review June 6, 2025 17:28
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 6, 2025
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. Otherwise, LGTM!

@@ -66,12 +66,12 @@ The following values are associated with the days of the week on which you want
These values are only applicable if you specify the frequency of scan as `Weekly` or `Monthly`.
====

*** *Time*: Start to type the time in `hh:mm` at which you want to run the scan. From the list that is displayed, select a time.
*** *Time*: Start to type the time in `hh:mm` at which you want to run the scan. From the list that is displayed, select a time. You can proceed to the next step only after you specify the time at which you want to run the scan.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*** *Time*: Start to type the time in `hh:mm` at which you want to run the scan. From the list that is displayed, select a time. You can proceed to the next step only after you specify the time at which you want to run the scan.
*** *Time*: Start to type the time in `hh:mm` at which you want to run the scan. From the list that is displayed, select a time. You can proceed to the next step only after you specify the time when you want to run the scan.


. Click *Next*.
. In the *Clusters* page, select one or more clusters that you want to include in the scan.
. In the *Clusters* page, select one or more clusters that you want to include in the scan. You can proceed to the next step only after you select at least one cluster which is in a healthy state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. In the *Clusters* page, select one or more clusters that you want to include in the scan. You can proceed to the next step only after you select at least one cluster which is in a healthy state.
. In the *Clusters* page, select one or more clusters that you want to include in the scan. You can proceed to the next step only after you select at least one cluster that is in a healthy state.

. Click *Next*.
. In the *Profiles* page, select one or more profiles that you want to include in the scan.
. In the *Profiles* page, select one or more profiles that you want to include in the scan. You can proceed to the next step only after you select at least one profile which you want to include in the scan.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. In the *Profiles* page, select one or more profiles that you want to include in the scan. You can proceed to the next step only after you select at least one profile which you want to include in the scan.
. In the *Profiles* page, select one or more profiles that you want to include in the scan. You can proceed to the next step only after you select at least one profile that you want to include in the scan.

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants