Skip to content

OSDOCS#34373: Making update permission optional for creating routes #96060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2025
@lunarwhite
Copy link
Member

/lgtm

@lunarwhite
Copy link
Member

Hi @snarayan-redhat, I think we are good to merge this 🚀

@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-34373_extsecrets branch from 686b1aa to df30dad Compare July 21, 2025 12:02
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2025
Copy link

openshift-ci bot commented Jul 21, 2025

@snarayan-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lunarwhite
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2025
@snarayan-redhat snarayan-redhat merged commit 4ff3c09 into openshift:main Jul 21, 2025
2 checks passed
@snarayan-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.18

@snarayan-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.19

@snarayan-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@snarayan-redhat: #96060 failed to apply on top of branch "enterprise-4.18":

Applying: Modified sentence for a clearer message
Using index info to reconstruct a base tree...
M	modules/cert-manager-configuring-routes.adoc
M	modules/nw-ingress-route-secret-load-external-cert.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-ingress-route-secret-load-external-cert.adoc
Auto-merging modules/cert-manager-configuring-routes.adoc
CONFLICT (content): Merge conflict in modules/cert-manager-configuring-routes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Modified sentence for a clearer message

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@snarayan-redhat: new pull request created: #96402

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@snarayan-redhat: #96060 failed to apply on top of branch "enterprise-4.20":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snarayan-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@snarayan-redhat: new pull request created: #96412

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snarayan-redhat snarayan-redhat changed the title OSDOCS#3437: Making update permission optional for creating routes OSDOCS#34373: Making update permission optional for creating routes Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants