-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-13052: updates and clarifies API server custom CAs MicroShift #96169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ShaunaDiaz: This pull request references OSDOCS-13052 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Mon Aug 04 15:29:26 - Prow CI generated the docs preview: |
@ShaunaDiaz: This pull request references OSDOCS-13052 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve, I can't judge the correctness, not being SME, not only if I understand better, and I do.
microshift_configuring/microshift_auth_security/microshift-custom-ca.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/LGTM |
@ShaunaDiaz: This pull request references OSDOCS-13052 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShaunaDiaz The PR and links look good, so feel free to merge this. I added a few comments about revisions to consider in another PR.
microshift_configuring/microshift_auth_security/microshift-custom-ca.adoc
Show resolved
Hide resolved
b8e5346
to
dd81a4b
Compare
dd81a4b
to
d4418d8
Compare
@ShaunaDiaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.20 |
@ShaunaDiaz: new pull request created: #97088 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #97089 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.19+
Issue:
OSDOCS-13052
Link to docs preview:
MicroShift API server custom certificate authority
QE review: