Skip to content

OSDOCS-13052: updates and clarifies API server custom CAs MicroShift #96169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Jul 16, 2025

Version(s):
4.19+

Issue:
OSDOCS-13052

Link to docs preview:
MicroShift API server custom certificate authority

QE review:

  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

@ShaunaDiaz: This pull request references OSDOCS-13052 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-13052

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 16, 2025
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jul 16, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 16, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

@ShaunaDiaz: This pull request references OSDOCS-13052 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-13052

Link to docs preview:
MicroShift API server custom certificate authority

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@ericzolf ericzolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve, I can't judge the correctness, not being SME, not only if I understand better, and I do.

tedaveryredhat

This comment was marked as off-topic.

Copy link

@DanielFroehlich DanielFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jogeo
Copy link

jogeo commented Jul 31, 2025

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2025

@ShaunaDiaz: This pull request references OSDOCS-13052 which is a valid jira issue.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-13052

Link to docs preview:
MicroShift API server custom certificate authority

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
Copy link

openshift-ci bot commented Jul 31, 2025

New changes are detected. LGTM label has been removed.

@ShaunaDiaz ShaunaDiaz added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 31, 2025
@lahinson lahinson added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 1, 2025
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShaunaDiaz The PR and links look good, so feel free to merge this. I added a few comments about revisions to consider in another PR.

@ShaunaDiaz ShaunaDiaz added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Aug 4, 2025
Copy link

openshift-ci bot commented Aug 4, 2025

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit 567484f into openshift:main Aug 4, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor Author

/cherrypick enterprise-4.19

@ShaunaDiaz
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #97088

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #97089

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-merge size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants